Adjustments to Logging and a Python Error #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xref_length was erroring on the old version of PyMuPDF. mupdf_display_errors errored with the new version, so it was removed. Image extraction from PDFs is a new feature.
Fix PDF scanner + support image extraction
Return all ExifTool tags, aka ignore input
Does not publish 'latest'. Leaving that separate (I'll come to it later) in order to promote immutable releases.
This allows simpler and more consistent distribution, and is fully backwards compatible -- these files are all referenced from the still required backend config, but the remaining required configurations are all host addresses, timeouts, sizes, etc.
Add GitHub Actions
Build in scanner, pw, and yara rules
* More adjustments to scanners
* Replace 'release-candidate' w/ semver Forgot release candidate in one spot, and now I just figure might as well check main semver instead of an artificial tag. * Add repo checkout to tag latest step * Otherwise it's missing for checking x-region replication
* Vendor all go commands together Having a go.mod file per cmd was responsible depending on this repo within the go.mod file. This prevents immediately consuming changes in the api or pkg directories and generally seemed odd. Import paths are still target/strelka instead of sublime-security/strelka so a replace is used in go.mod. We could change this. It should matter whether the repos local directory is in target or sublime-security. * Adjust Dockerfile
* Only tag full version number The docker files pull a lot of dependencies which make them susceptable to transiently breaking. It'll be important that we test images adequetly before "releasing". Since the major/minor and major tags would update immediately this could cause a new image to be consumed before any testing. If we need these tags we should move them to the update latest workflow. Of course we can also put more effort into making the build reliable, but that's more involved. * latest workflow update major & major.minor tags These tags are what we use in docker compose and I think they make enough sense to continue with, but I still do want to have the chance to test any image before anything could auto upgrade.
|
I once again apologize -- I really wish I could default to merging to the fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Include a summary of the change (with required dependencies), any issues it fixes, and relevant motivation and context.
Describe testing procedures
Describe the tests that you ran to verify your changes (including test configurations) and instructions so we can reproduce the tests. To assist in testing, the project maintainers may ask for file samples.
Sample output
If this change modifies Strelka's output, then please include a sample of the output here.
Checklist