Only tag full version number #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker files pull a lot of dependencies which make them susceptable to transiently breaking. It'll be important that we test images adequetly before "releasing". Since the major/minor and major tags would update immediately this could cause a new image to be consumed before any testing. If we need these tags we should move them to the update latest workflow. Of course we can also put more effort into making the build reliable, but that's more involved.
These tags are what we use in docker compose and I think they make enough sense to continue with, but I still do want to have the chance to test any image before anything could auto upgrade.
jkamdjou
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker files pull a lot of dependencies which make them
susceptible to transiently breaking. It'll be important that
we test images adequately before "releasing". Since the major/minor
and major tags would update immediately this could cause a new
image to be consumed before any testing. If we need these tags
we should move them to the update latest workflow.
Of course we can also put more effort into making the build reliable,
but that's more involved.