追加: ShellCheck CI (VOICEVOX#1125)

* add: ShellCheck CI * fix: パス解決 lint エラーを回避 * fix: ls-grep を if で置き換え * fix: grep を glob で置換し lint エラーを解消 * refactor: workflow step 名を明確化 * fix: workflow ジョブ名を明確化 Co-authored-by: Hiroshiba <[email protected]> --------- Co-authored-by: Hiroshiba <[email protected]>
tarepan · May 14, 2024 · 01fcc6d · 01fcc6d
1 parent 9751d6e
commit 01fcc6d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -75,3 +75,17 @@ jobs:
       - name: Test names by checking typo
         if: ${{ startsWith(matrix.os, 'ubuntu-') }}
         uses: crate-ci/[email protected]
+
+  shellcheck:
+    runs-on: ubuntu-20.04
+    steps:
+      - name: <Setup> Check out the repository
+        uses: actions/checkout@v4
+
+      - name: <Setup> Install ShellCheck
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y shellcheck
+
+      - name: <Test> Check shell files
+        run: git ls-files | grep -E '\.(ba)?sh' | xargs shellcheck
diff --git a/build_util/create_venv_and_generate_licenses.bash b/build_util/create_venv_and_generate_licenses.bash
@@ -11,10 +11,10 @@ VENV_PATH="licenses_venv"
 
 python -m venv $VENV_PATH
 if [ -d "$VENV_PATH/Scripts" ]; then
-    # shellcheck disable=SC1091
+    # shellcheck disable=SC1091,SC1090
     source $VENV_PATH/Scripts/activate
 else
-    # shellcheck disable=SC1091
+    # shellcheck disable=SC1091,SC1090
     source $VENV_PATH/bin/activate
 fi
 

diff --git a/build_util/process_voicevox_resource.bash b/build_util/process_voicevox_resource.bash
@@ -22,6 +22,8 @@ python build_util/merge_update_infos.py \
     "${DOWNLOAD_RESOURCE_PATH}/engine/engine_manifest_assets/update_infos.json" \
     engine_manifest_assets/update_infos.json
 
-for f in $(ls "${DOWNLOAD_RESOURCE_PATH}"/engine/engine_manifest_assets/* | grep -v update_infos.json); do
-    cp "${f}" ./engine_manifest_assets/
+for f in "${DOWNLOAD_RESOURCE_PATH}"/engine/engine_manifest_assets/*; do
+    if [ "$(basename "${f}")" != "update_infos.json" ]; then
+        cp "${f}" ./engine_manifest_assets/
+    fi
 done