Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

追加: ShellCheck CI #1125

Merged
merged 6 commits into from
May 14, 2024
Merged

追加: ShellCheck CI #1125

merged 6 commits into from
May 14, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Mar 18, 2024 •
edited
Loading

内容

ShellCheck を CI に追加し GitHub Actions workflow の自動 linting を追加した。

また CI 導入により顕在化する lint エラーを修正した。出力値の完全一致を確認済みである。

関連 Issue

part of #525

@tarepan tarepan changed the title add: ShellCheck CI 追加: ShellCheck CI Mar 18, 2024
@tarepan tarepan force-pushed the add/shellcheck_ci branch 2 times, most recently from 2ce8308 to 5fed9b6 Compare April 7, 2024 15:58
@tarepan tarepan force-pushed the add/shellcheck_ci branch from b1e6313 to c735497 Compare May 6, 2024 08:11
@tarepan tarepan marked this pull request as ready for review May 6, 2024 11:52
@tarepan tarepan requested a review from a team as a code owner May 6, 2024 11:52
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 6, 2024 11:52
Hiroshiba
Hiroshiba reviewed May 12, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼ lgtm です！！

調べてくださってありがとうございます！
bashで"$(basename "${f}")"が合法なの知りませんでした･･･。

.github/workflows/test.yml Outdated Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented May 12, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Hiroshiba
Hiroshiba approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit 01fcc6d into VOICEVOX:master May 14, 2024
4 checks passed
@tarepan tarepan deleted the add/shellcheck_ci branch May 14, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarepan @Hiroshiba