Replace LegacyPlasmaArray with a function #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ftsamis should we merge this one? |
|
@wkerzendorf Not yet, I'm doing some tests first. |
ftsamis
force-pushed
the
restructure-plasma
branch
2 times, most recently
from
2ebdac3
to
2904694
Compare
ftsamis
force-pushed
the
restructure-plasma
branch
from
e775ea0
to
892a641
Compare
ftsamis
force-pushed
the
restructure-plasma
branch
from
892a641
to
2e56ac3
Compare
|
Note: It's not possible to initialize property classes with the current state of this PR, which replaces the super-class Details: https://gitter.im/tardis-sn/tardis?at=57a9f1f2f7f11a7936af6afc |
ftsamis
force-pushed
the
restructure-plasma
branch
from
e8384d6
to
c807ba0
Compare
|
Closing in favor of #652. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
LegacyPlasmaArrayis replaced withassemble_plasmawhich takes aConfigurationobject and aRadial1DModel(in the form it has in #632) and returns aBasePlasmainstance.