Restructure Radial1DModel #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model if it's None.
Organize the different density types in descriptor classes in the model.density module. Add a way of creating the restructured Radial1DModel from a Configuration object.
Closed
This was referenced Jul 25, 2016
Use time_explosion as time_0 if the latter was not provided in the configuration.
|
I have added an option to provide |
ftsamis
force-pushed
the
restructure-model
branch
from
92aa892
to
c762965
Compare
|
Closing in favor of #652. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to rewrite the
Radial1DModelclass to make it more dynamic and add a proper__init__method to it, which accepts all the required arguments for the model. Also, attributes and methods that do not belong to the model should be removed from it with this PR.The main idea is to have some base attributes to the model, and then provide dynamic arguments (i.e. python properties) which are (re)calculated every time they are accessed from the base attributes. This way, if a base attribute is changed, everything that depends on it will reflect the changes.
Additionally,
__init__should now take the actual base attributes that model needs instead of a config object, while we will still have afrom_configclassmethod which will create a model from a config object.