Merge to_hdf #606
Merged
Merge to_hdf #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a to_hdf method to the MontecarloRunner. * Also store nu_bar_estimator and j_estimator in runner's to_hdf * Document MontecarloRunner.property_to_hdf
|
@ftsamis all mine when travis passes. |
|
@wkerzendorf All yours! 😛 |
|
|
||
|
|
||
|
|
||
| class TARDISSpectrum(object): |
There was a problem hiding this comment.
remove this - not sure why this is even in there.
Add a method to store every iteration of the Simulation to a specified HDF file.
Store the v_inner, v_outer as model attributes. Furthermore, convert v_middle from a property to an attribute as well
| @@ -90,21 +91,24 @@ def __init__(self, tardis_config): | |||
|
|
|||
| self.t_inner = tardis_config.plasma.t_inner | |||
|
|
|||
| self.v_inner = tardis_config.structure.v_inner | |||
| self.v_outer = tardis_config.structure.v_outer | |||
| self.v_middle = 0.5 * (self.v_inner + self.v_outer) | |||
There was a problem hiding this comment.
It's just a small thing which isn't important here. But in general one should prefer 0.5 * x + 0.5 * y to prevent overflowing.
|
|
||
| from tardis.io.util import to_hdf |
There was a problem hiding this comment.
I feeld it would look cleaner if we did import tardis.io.util and then use tardis.io.util.to_hdf.
Just a remark, not something need to fix before merging.
|
@yeganer i'm going to merge now, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the merge PR for
tardis-sn/tardis/to_hdf, rebased tomaster, since there were a few conflicts.