Memory issue #420
Merged
Memory issue #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unoebauer @chvogl if there are no further objections - I'll merge this. |
|
In principle this looks reasonable - we are currently checking whether this could also help with the bf-integration of @chvogl |
|
Looks ok - merge at will |
|
@unoebauer does this solve your problem? |
wkerzendorf
added a commit
that referenced
this pull request
Oct 6, 2015
|
I think it is definitely a step in the right direction - we will test the same concept with the bf-integration. But I think that the garbage collector should now not interfere any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419 - I think. So this is I guess a good for problems of this class: We attach a "permanent" pointer to the runner class (the runner class is exactly for this to hold data for the C-part of TARDIS). @chvogl @unoebauer can you run your toolkit to see if there are any other dropped references - so we can make sure this works there.