Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with inverse electron densities - no packets are escaping #419

Closed
unoebauer opened this issue Oct 2, 2015 · 3 comments
Closed

Comments

@unoebauer
Copy link
Contributor

Some weird behaviour in the new plasma calculation or/and in the new layout or the montecarlo.pyx file lead to the following severe problem:

During each montecarlo packet propagation cycle, not a single packet escaped through the outer boundary of the computational domain. It seems that the simulation thinks that the distance to the next electron scattering event is zero. Thus, all injected packets immediately scatter and are eventually lost at the inner boundary. Somehow, probably somewhere in the montecarlo.pyx file the inverse electron densities are messed up (potentially pointing to uninitialised memory).

@unoebauer
Copy link
Contributor Author

After updating to the current master AND updating the pandas library to pandas 0.16.2, the problem seems to have disappeared.

However, @chvogl seems to have run into the same problem with the current master.

@wkerzendorf
Copy link
Member

@unoebauer so you do not get a problem anymore with the current master and a new pandas version. If you have the machinery running to check for missing references specifically in init_storage_model, then we can make sure these are fixed. let me know, which ones these are. I have had a similar problem before, but I fixed it before merging. It resulted in the full tardis test failing.

@chvogl
Copy link
Contributor

chvogl commented Oct 2, 2015

I encountered the same problem, when I tried to add some additional data for the continuum implementation in the initalize_storage_model function.
For unknown reasons this resulted in the cleanup of the inverse_electron_densities by the garbage collector. As a result the pointer to the inverse electron densities pointed to values of the order 1e-300.
As a consequence the distance to the next continuum event was always zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants