Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename T to temperature #1961

Closed
wants to merge 3 commits into from
Closed

Rename T to temperature #1961

wants to merge 3 commits into from

Conversation

ArneWouters
Copy link

Description

Rename T variables to temperature in the code

Motivation and context

Closes #1600

How has this been tested?

  • Testing pipeline.
  • Other. pytest tardis --tardis-refdata=~/Downloads/tardis-refdata

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above. Refactoring

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #1961 (d9496ff) into master (b54dc86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1961   +/-   ##
=======================================
  Coverage   59.85%   59.85%           
=======================================
  Files          70       70           
  Lines        8080     8080           
=======================================
  Hits         4836     4836           
  Misses       3244     3244           
Impacted Files Coverage Δ
tardis/tardis/montecarlo/packet_source.py 97.43% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@andrewfullard
Copy link
Contributor

Good work!

@epassaro epassaro closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename T to temperature across the code
4 participants