Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the new configuration on require('config'):get() in the role. #9649

Closed
ImeevMA opened this issue Feb 5, 2024 · 0 comments · Fixed by #9651
Closed

Return the new configuration on require('config'):get() in the role. #9649

ImeevMA opened this issue Feb 5, 2024 · 0 comments · Fixed by #9651
Assignees
Labels
3.0 Target is 3.0 and all newer release/master branches bug Something isn't working config

Comments

@ImeevMA
Copy link
Collaborator

ImeevMA commented Feb 5, 2024

Currently, require('config'):get() throws an error if executed in a role that is applied at config startup. If require('config'):get() is executed in a role that is applied at config reload, it returns the previous configuration.

The expected behavior is to return the configuration that is currently applied.

@ImeevMA ImeevMA added bug Something isn't working config labels Feb 5, 2024
@ImeevMA ImeevMA self-assigned this Feb 5, 2024
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Feb 5, 2024
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes tarantool#9649

NO_DOC=bugfix
@Totktonada Totktonada added the 3.0 Target is 3.0 and all newer release/master branches label Feb 6, 2024
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Feb 7, 2024
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes tarantool#9649

NO_DOC=bugfix
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Feb 7, 2024
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes tarantool#9649

NO_DOC=bugfix
Totktonada pushed a commit that referenced this issue Feb 7, 2024
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes #9649

NO_DOC=bugfix
Totktonada pushed a commit to Totktonada/tarantool that referenced this issue Feb 7, 2024
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes tarantool#9649

NO_DOC=bugfix

(cherry picked from commit ebb170c)
Totktonada pushed a commit that referenced this issue Feb 9, 2024
Roles are now started and stopped at the "post_apply" stage rather than
at the "apply" stage. This allows require('config'):get() to correctly
return the configuration that is being applied.

Closes #9649

NO_DOC=bugfix

(cherry picked from commit ebb170c)
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 27, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 27, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 27, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 27, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 27, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 27, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 28, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 28, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 28, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 28, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 29, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Mar 29, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Apr 1, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Apr 1, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Apr 2, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Apr 2, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
DifferentialOrange added a commit to tarantool/crud that referenced this issue Apr 3, 2024
This patch introduce basic crud-router and crud-storage roles for
Tarantool 3. The roles are similar to Cartridge ones.
Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2].

This commit makes all existing config tests run with roles enabled
instead of manual bootstrap.

This commit does not yet introduce metrics configuration through roles
config.

[1] tarantool/tarantool#9643
[2] tarantool/tarantool#9649

Part of #415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Target is 3.0 and all newer release/master branches bug Something isn't working config
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants