Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tarantool dependency to >= 3.0.2 #25

Closed
DifferentialOrange opened this issue Nov 11, 2024 · 0 comments · Fixed by #27
Closed

Bump tarantool dependency to >= 3.0.2 #25

DifferentialOrange opened this issue Nov 11, 2024 · 0 comments · Fixed by #27
Assignees
@themilchenko
Labels
1sp bug Something isn't working teamE

Comments

@DifferentialOrange
Copy link
Member

config:get inside roles doesn't work properly on 3.0.1:

metrics-export-role/roles/metrics-export.lua

Line 160 in 2f25cb0

local httpd_roles_cfg = (require("config"):get("roles_cfg") or {})['roles.httpd']

It was solved in 3.0.2, 3.1.0 and newer: tarantool/tarantool#9649
@oleg-jukovec oleg-jukovec added 1sp teamE bug Something isn't working labels Nov 11, 2024
themilchenko added a commit that referenced this issue Nov 19, 2024
@themilchenko
rockspec: update tarantool version
5dcd03b 
`config:get` method inside roles doesn't work properly on Tarantool
3.0.1.

Update tarantool dependency to the `>=3.0.2` version, so the `config:get()`
works without problems.

Closes #25
@themilchenko themilchenko mentioned this issue Nov 19, 2024
Merged
themilchenko added a commit that referenced this issue Nov 19, 2024
@themilchenko
rockspec: update tarantool version
9b07b10 
`config:get` method inside roles doesn't work properly on Tarantool
3.0.1.

Update tarantool dependency to the `>=3.0.2` version, so the `config:get()`
works without problems.

Closes #25
@themilchenko themilchenko self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@themilchenko themilchenko

Labels
1sp bug Something isn't working teamE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rockspec: update tarantool version tarantool/metrics-export-role
3 participants
@DifferentialOrange @oleg-jukovec @themilchenko