Refactor metrics.utils and change type of luajit metrics #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
reviewed
Aug 24, 2021
| @@ -1,30 +1,9 @@ | |||
| local metrics = require('metrics') | |||
There was a problem hiding this comment.
I hope you considered this thread when push this changes #128 (comment)
metrics/tarantool/luajit.lua
Outdated
| @@ -34,46 +13,52 @@ local function update() | |||
| -- Details: https://github.com/tarantool/doc/issues/1597 | |||
| local lj_metrics = misc.getmetrics() | |||
| collectors_list.gc_freed = | |||
| set_counter('gc_freed', 'Total amount of freed memory', lj_metrics.gc_freed) | |||
| utils.set_gauge('gc_freed', 'Total amount of freed memory', lj_metrics.gc_freed, nil, LJ_PREFIX) | |||
There was a problem hiding this comment.
There was some ideas on reset/inc counter approach for monotonic metrics here: #128 (comment) . Maybe we should use this approach when #288 (review) instead of the current one? For example, when using prometheus the type of metric is shown in Grafana UI.
yngvar-antonsson
force-pushed
the
refactor-luajit-metrics
branch
from
eb44fe3 to
2b31488
Compare
yngvar-antonsson
force-pushed
the
refactor-luajit-metrics
branch
from
2b31488 to
77991b6
Compare
DifferentialOrange
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luajit metrics should be gauge, because they're set in Tarantool, not metrics module.
I also refactor metrics.utils module and remove unused internal function
prefix_namefrom it's API.@DifferentialOrange, will it affect Grafana dashboard?
I didn't forget about
Close #277