Add counter:reset method #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,4 +9,8 @@ function Counter:inc(num, label_pairs) | |||
| Shared.inc(self, num, label_pairs) | |||
| end | |||
|
|
|||
| function Counter:reset(label_pairs) | |||
There was a problem hiding this comment.
The original request was about counter initialization. Initialization with counter:reset(label_pairs) seems kinda weird. How about adding an alias for reset as a little syntactic sugar?
Counter.initialize = reset
There was a problem hiding this comment.
init / reinit / reset, who cares. Reset is better than inc(0), and that's the purpose.
There was a problem hiding this comment.
Init which resets the value may be considered weird too.
yngvar-antonsson
force-pushed
the
collector-reset
branch
2 times, most recently
from
85ddf9d to
762ef62
Compare
yngvar-antonsson
force-pushed
the
collector-reset
branch
from
762ef62 to
cbe4a3e
Compare
DifferentialOrange
approved these changes
Aug 24, 2021
1 task
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't forget about
Close #260