-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bindings for DANE #14
Conversation
Thank you for the patch! Please, fix the CI errors:
before a review. |
@oleg-jukovec Sorry for the inconvenience, I didn't enable actions on the fork... Everything should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch! Overall you did a great work, docs are clear and codestyle is on the level. That was a pleasure to review this patch.
But there are still some moments I would like you to fix or discuss with us:
- You should squish your commits into one (or more, but logically separated). Right now its a mess, some commits are breaking the CI, some revert changes from other commits.
Please, also write a commit message body (if needed) to explain the changes done for each commit. You can refer to the commit history the master branch. - In Tarantool every commit should end with a dot. Thank you for following this rule for code comments, but there are some missing dots in
CHANGELOG
andREADME
. - There are some other nits and questions described below. Please forgive me in case of being too pedantic and don't be afraid to engage in dialogue with me. I hope all the comments are clear.
Another thing I forgot about is the lack of tests. Is there any difficulties writing unit tests for new methods? |
0f86b1e
to
a875f95
Compare
No, for our applications this was covered by e2e tests but that's of course not the case for this library. I'll write some |
Everything should be resolved now. Please have a look and I'll squash the commits @DerekBum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing all the countless nits I had! Everything looks great, CI is all green. Just a couple of comment fixes left (just them, everything else is ok).
I will approve this PR after the squash.
Everything's squashed now, thanks for the quick review! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the patch!
@coma64 do you need a release version with the patchset? |
Yes please |
Overview
First of all, thanks for keeping this library maintained :D
This PR adds CGO bindings for a bunch of openssl function, most notably DANE (DNS-based Authentication of Named Entities) related functions.
New features
X509_digest()
X509_verify_cert_error_string()
SSL_get_version()