Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alexander Tulchinskiy  <[email protected]>
  • Loading branch information
coma64 and DerekBum authored Aug 30, 2024
1 parent 26b0446 commit ffeccb7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ssl.go
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,13 @@ func (s *SSL) DaneGet0DaneAuthority() int {
return int(C.SSL_get0_dane_authority(s.ssl, nil, nil))
}

// DaneSetFlags enables the given flags for this connection. Returns the old flags.
// DaneSetFlags enables given flags for this connection. Returns previous flags.
// https://www.openssl.org/docs/man1.1.1/man3/SSL_dane_clear_flags.html
func (s *SSL) DaneSetFlags(flags DaneFlags) DaneFlags {
return DaneFlags(C.SSL_dane_set_flags(s.ssl, C.ulong(flags)))
}

// DaneClearFlags disables flags set by DaneSetFlags. Returns the old flags.
// DaneClearFlags disables flags set by DaneSetFlags. Returns previous flags.
func (s *SSL) DaneClearFlags(flags DaneFlags) DaneFlags {
return DaneFlags(C.SSL_dane_clear_flags(s.ssl, C.ulong(flags)))
}
Expand Down
4 changes: 2 additions & 2 deletions ssl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1000,10 +1000,10 @@ func TestOpenSSLGetVersion(t *testing.T) {
}

if ok := ctx.SetMinProtoVersion(TLS1_3_VERSION); !ok {
t.Fatal("Failed to TLS min version")
t.Fatal("Failed to set TLS min version")
}
if ok := ctx.SetMaxProtoVersion(TLS1_3_VERSION); !ok {
t.Fatal("Failed to TLS max version")
t.Fatal("Failed to set TLS max version")
}

client, err := Client(clientConn, ctx)
Expand Down

0 comments on commit ffeccb7

Please sign in to comment.