ddl: support sequences #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-122-sequences
branch
3 times, most recently
from
5b951c5 to
39bf083
Compare
psergee
approved these changes
Mar 27, 2024
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-122-sequences
branch
from
39bf083 to
4b02448
Compare
This patch adds the support of sequences through new schema section, as well as proper support of sequence option for indexes. Before this patch, ddl had half-baked support of sequences: one could provide `sequence` as sequence name in indexes and it would be created. This approach was broken in basic `set_schema(get_schema)` scenario since there wasn't any sequences support in get. Current design is inspired by existing "not implemented yet" tests and documentation examples. Closes #122
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-122-sequences
branch
from
4b02448 to
57c3242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the support of sequences through new schema section, as well as proper support of sequence option for indexes. Before this patch, ddl had half-baked support of sequences: one could provide
sequenceas sequence name in indexes and it would be created. This approach was broken in basicset_schema(get_schema)scenario since there wasn't any sequences support in get. Current design is inspired by existing "not implemented yet" tests and documentation examples.Closes #122