Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequence info is missing in schema returned from get_schema #122

Closed
psergee opened this issue Mar 19, 2024 · 0 comments · Fixed by #123
Closed

sequence info is missing in schema returned from get_schema #122

psergee opened this issue Mar 19, 2024 · 0 comments · Fixed by #123
Assignees
@DifferentialOrange
Labels
bug Something isn't working teamE

Comments

@psergee
Copy link

psergee commented Mar 19, 2024

How to reproduce:
Actual index info:

box.space._migrations.index
---
- 0: &0
    parts:
    - type: unsigned
      is_nullable: false
      fieldno: 1
    sequence_id: 1
    id: 0
    space_id: 512
    unique: true
    hint: true
    type: TREE
    name: primary
    sequence_fieldno: 1
  primary: *0

DDL schema:

ddl.get_schema().spaces._migrations.indexes
---
- - type: TREE
    parts:
    - path: id
      is_nullable: false
      type: unsigned
    name: primary
    unique: true

Sequence is missing. So, after applying cluster-wide schema from ddl.get-schema index sequence configuration is lost.
@psergee psergee added bug Something isn't working teamE labels Mar 19, 2024
@DifferentialOrange DifferentialOrange self-assigned this Mar 20, 2024
DifferentialOrange added a commit that referenced this issue Mar 20, 2024
@DifferentialOrange
[WIP] ddl: support sequences
a03cf9c 
Closes #122
DifferentialOrange added a commit that referenced this issue Mar 21, 2024
@DifferentialOrange
ddl: support sequences
5b951c5 
This patch adds the support of sequences through new schema section,
as well as proper support of sequence option for indexes. Before this
patch, ddl had half-baked support of sequences: one could provide
`sequence` as sequence name in indexes and it would be created. This
approach was broken in basic `set_schema(get_schema)` scenario since
there wasn't any sequences support in get. Current design is inspired
by existing "not implemented yet" tests and documentation examples.

Closes #122
@DifferentialOrange DifferentialOrange mentioned this issue Mar 21, 2024
Merged
DifferentialOrange added a commit that referenced this issue Mar 21, 2024
@DifferentialOrange
ddl: support sequences
39bf083 
This patch adds the support of sequences through new schema section,
as well as proper support of sequence option for indexes. Before this
patch, ddl had half-baked support of sequences: one could provide
`sequence` as sequence name in indexes and it would be created. This
approach was broken in basic `set_schema(get_schema)` scenario since
there wasn't any sequences support in get. Current design is inspired
by existing "not implemented yet" tests and documentation examples.

Closes #122
DifferentialOrange added a commit that referenced this issue Mar 28, 2024
@DifferentialOrange
ddl: support sequences
4b02448 
This patch adds the support of sequences through new schema section,
as well as proper support of sequence option for indexes. Before this
patch, ddl had half-baked support of sequences: one could provide
`sequence` as sequence name in indexes and it would be created. This
approach was broken in basic `set_schema(get_schema)` scenario since
there wasn't any sequences support in get. Current design is inspired
by existing "not implemented yet" tests and documentation examples.

Closes #122
DifferentialOrange added a commit that referenced this issue Mar 28, 2024
@DifferentialOrange
ddl: support sequences
57c3242 
This patch adds the support of sequences through new schema section,
as well as proper support of sequence option for indexes. Before this
patch, ddl had half-baked support of sequences: one could provide
`sequence` as sequence name in indexes and it would be created. This
approach was broken in basic `set_schema(get_schema)` scenario since
there wasn't any sequences support in get. Current design is inspired
by existing "not implemented yet" tests and documentation examples.

Closes #122
DifferentialOrange added a commit that referenced this issue Apr 10, 2024
@DifferentialOrange
ddl: support sequences
dd59559 
This patch adds the support of sequences through new schema section,
as well as proper support of sequence option for indexes. Before this
patch, ddl had half-baked support of sequences: one could provide
`sequence` as sequence name in indexes and it would be created. This
approach was broken in basic `set_schema(get_schema)` scenario since
there wasn't any sequences support in get. Current design is inspired
by existing "not implemented yet" tests and documentation examples.

Closes #122
DifferentialOrange added a commit that referenced this issue Apr 10, 2024
@DifferentialOrange
release 1.7.0
e1883dc 
Overview

  This release introduces sequences support in schema and space indexes.

New features

  - Added support of sequences in schema and space indexes (#122).
@DifferentialOrange DifferentialOrange mentioned this issue Apr 10, 2024
Merged
DifferentialOrange added a commit that referenced this issue Apr 10, 2024
@DifferentialOrange
release 1.7.0
8b86b65 
Overview

  This release introduces sequences support in schema and space indexes.

New features

  - Added support of sequences in schema and space indexes (#122).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DifferentialOrange DifferentialOrange

Labels
bug Something isn't working teamE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: support sequences tarantool/ddl
2 participants
@DifferentialOrange @psergee