-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crud: introduce tarantool 3 roles #427
Merged
DifferentialOrange
merged 11 commits into
master
from
DifferentialOrange/gh-415-role-for-tarantool3
Apr 3, 2024
Merged
crud: introduce tarantool 3 roles #427
DifferentialOrange
merged 11 commits into
master
from
DifferentialOrange/gh-415-role-for-tarantool3
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
2 times, most recently
from
March 26, 2024 08:43
0a352fe
to
106f2aa
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
March 26, 2024 08:44
fc50243
to
d080a31
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
from
March 26, 2024 08:53
106f2aa
to
ab1a690
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
March 26, 2024 09:34
d080a31
to
97b008d
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
from
March 26, 2024 09:44
ab1a690
to
e2b8486
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
March 26, 2024 12:23
97b008d
to
483d7e0
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
from
March 26, 2024 13:09
e2b8486
to
b21560e
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
7 times, most recently
from
March 27, 2024 07:22
6b51642
to
91168b4
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
2 times, most recently
from
March 27, 2024 13:23
cfbc6b3
to
195881f
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
5 times, most recently
from
March 27, 2024 17:29
e32dcc9
to
15011d6
Compare
A single time cluster had started with broken vshard and |
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
March 27, 2024 17:39
15011d6
to
3f15368
Compare
DifferentialOrange
changed the title
[WIP] Role for Tarantool 3
crud: introduce tarantool 3 roles
Mar 28, 2024
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
4 times, most recently
from
March 28, 2024 10:00
8ec877e
to
3c6749f
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
March 29, 2024 11:14
3c6749f
to
cf2dc02
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
from
March 29, 2024 14:29
195881f
to
3a7328b
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
March 29, 2024 14:29
cf2dc02
to
eb14f0e
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
from
April 1, 2024 11:47
3a7328b
to
ce65f86
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
2 times, most recently
from
April 1, 2024 13:48
f37b0c3
to
df1ede6
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-412-3.0-grants
branch
from
April 1, 2024 16:18
ce65f86
to
14864f2
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
April 2, 2024 07:26
df1ede6
to
ba62a52
Compare
After this patch, it is possible to start a Tarantool 3.0 cluster from the config for tests. It doesn't yet integrated with common test matrix yet. The tests are basic and shallow since it would be tested against the whole crud test suite in the next commits of the patchset. Part of #415
After this patch, all unit and integration tests run also on cluster started from configuration file. Part of #415
Sometimes it is possible to get a vshard router with broken connection to a storage. It seems that existing 5 seconds timeout does not allow to reconnect to a storage, so we try to increase it. Part of #415
Logging to file is not captured by luatest, so debugging in case cluster start had failed is nearly impossible.
Before this patch, it was possible to get a successful storage info response, while some replicas still could be treated as erroneous (backoff) by vshard ro calls.
This patch introduce basic crud-router and crud-storage roles for Tarantool 3. The roles are similar to Cartridge ones. Roles support Tarantool 3.0.2, Tarantool 3.1.0 and newer due to [1, 2]. This commit makes all existing config tests run with roles enabled instead of manual bootstrap. This commit does not yet introduce metrics configuration through roles config. [1] tarantool/tarantool#9643 [2] tarantool/tarantool#9649 Part of #415
This patch introduces `roles.crud-router` role configuration through `roles_cfg`, similar to existing Cartridge clusterwide configuration support. For now, storages don't have any configuration, so they remain unchanged. After this patch, Tarantool 3 roles have all features supported in Cartridge roles. Closes #415
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-415-role-for-tarantool3
branch
from
April 2, 2024 07:55
ba62a52
to
c106a7a
Compare
oleg-jukovec
approved these changes
Apr 3, 2024
DifferentialOrange
deleted the
DifferentialOrange/gh-415-role-for-tarantool3
branch
April 3, 2024 11:01
DifferentialOrange
added a commit
that referenced
this pull request
Apr 3, 2024
Overview This release introduces roles for Tarantool 3 configuration (supported for versions 3.0.2, 3.1.0 and newer). Added * Asynchronous bootstrap support for storages (#412). * Tarantool 3 roles for setting up crud routers and storages (#415). * Ability to configure crud through Tarantool 3 roles configuration (#415). Changed * Explicitly forbid datetime interval conditions (#373). * Storage initialization is now asynchronous by default for Tarantool 3.0+ (#412). * Additionally check backoff error on storage info fetch (#427). Fixed * Working with datetime conditions in case of non-indexed fields or non-iterating indexes (#373). * Precision loss for decimal conditions in case of non-indexed fields or non-iterating indexes (#373). * Passing errors from storages for merger operations (`crud.select`, `crud.pairs`, `readview:select`, `readview:pairs`) (#423). * Working with `nil` operand conditions in case of non-indexed fields or non-iterating indexes (#422).
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Apr 4, 2024
Overview This release introduces roles for Tarantool 3 configuration (supported for versions 3.0.2, 3.1.0 and newer). Added * Asynchronous bootstrap support for storages (#412). * Tarantool 3 roles for setting up crud routers and storages (#415). * Ability to configure crud through Tarantool 3 roles configuration (#415). Changed * Explicitly forbid datetime interval conditions (#373). * Storage initialization is now asynchronous by default for Tarantool 3.0+ (#412). * Additionally check backoff error on storage info fetch (#427). Fixed * Working with datetime conditions in case of non-indexed fields or non-iterating indexes (#373). * Precision loss for decimal conditions in case of non-indexed fields or non-iterating indexes (#373). * Passing errors from storages for merger operations (`crud.select`, `crud.pairs`, `readview:select`, `readview:pairs`) (#423). * Working with `nil` operand conditions in case of non-indexed fields or non-iterating indexes (#422).
DifferentialOrange
added a commit
that referenced
this pull request
May 20, 2024
Overview This release introduces roles for Tarantool 3 configuration (supported for versions 3.0.2, 3.1.0 and newer). Added * Asynchronous bootstrap support for storages (#412). * Tarantool 3 roles for setting up crud routers and storages (#415). * Ability to configure crud through Tarantool 3 roles configuration (#415). Changed * Explicitly forbid datetime interval conditions (#373). * Storage initialization is now asynchronous by default for Tarantool 3.0+ (#412). * Additionally check backoff error on storage info fetch (#427). Fixed * Working with datetime conditions in case of non-indexed fields or non-iterating indexes (#373). * Precision loss for decimal conditions in case of non-indexed fields or non-iterating indexes (#373). * Passing errors from storages for merger operations (`crud.select`, `crud.pairs`, `readview:select`, `readview:pairs`) (#423). * Working with `nil` operand conditions in case of non-indexed fields or non-iterating indexes (#422).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduce Tarantool 3 roles for crud routers and storages, similar to Cartridge ones. It also introduces testing with Tarantool 3 cluster started from configuration. See commits for more info.
I didn't forget about
Closes #415