crud: support vshard with no UUIDs in config #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-407-no-uuid
branch
8 times, most recently
from
5221c20 to
39479f5
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-407-no-uuid
branch
2 times, most recently
from
d874a7d to
5541879
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-407-no-uuid
branch
from
5541879 to
cb67ba3
Compare
Some read cases were missing in #404 test stabilization commit. This patch updates missing read cases. 1. https://github.com/tarantool/crud/actions/runs/7322196516/job/19943422319 Follows #404
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
Since dev_checks are disabled in production, it affects only tests.
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-407-no-uuid
branch
from
cb67ba3 to
c3250f0
Compare
better0fdead
suggested changes
Jan 10, 2024
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-407-no-uuid
branch
from
c3250f0 to
ecada81
Compare
better0fdead
approved these changes
Jan 10, 2024
DifferentialOrange
added a commit
that referenced
this pull request
Jan 23, 2024
Some read cases were missing in #404, #406 and #408 test stabilization commits. This patch updates missing read cases. 1. https://github.com/tarantool/crud/actions/runs/7322196516/job/19943422319 Follows #404
DifferentialOrange
added a commit
that referenced
this pull request
Jan 24, 2024
Some read cases were missing in #404, #406 and #408 test stabilization commits. This patch updates missing read cases. 1. https://github.com/tarantool/crud/actions/runs/7322196516/job/19943422319 Follows #404
DifferentialOrange
added a commit
that referenced
this pull request
Mar 22, 2024
Some read cases were missing in #404, #406 and #408 test stabilization commits. This patch updates missing read cases. 1. https://github.com/tarantool/crud/actions/runs/7322196516/job/19943422319 Follows #404
DifferentialOrange
added a commit
that referenced
this pull request
Mar 22, 2024
Some read cases were missing in #404, #406 and #408 test stabilization commits. This patch updates missing read cases. 1. https://github.com/tarantool/crud/actions/runs/7322196516/job/19943422319 Follows #404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue.
Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover
select_oldsince it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1].This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided.
identification_modevshard#460Follows #404
Closes #407