-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Сan't initialize storage/router if no UUIDs #407
Comments
DifferentialOrange
added a commit
that referenced
this issue
Dec 28, 2023
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Dec 28, 2023
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Dec 29, 2023
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Dec 29, 2023
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Part of #407
DifferentialOrange
changed the title
can't initialize storage/router with cluster config
Сan't initialize storage/router if no UUIDs
Dec 29, 2023
This was referenced Dec 29, 2023
DifferentialOrange
added a commit
that referenced
this issue
Dec 29, 2023
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Jan 9, 2024
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Jan 9, 2024
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Jan 10, 2024
PR #404 has introduced vshard 0.1.25 + Tarantool 3.0 "name as key" identification mode based on UUIDs extraction. If works fine if vshard configuration (or Tarantool 3.0 configuration which builds vshard one) provides UUIDs, but fails if it isn't. Since UUIDs are optional and won't be provided in most cases, it makes crud fails to work on most Tarantool 3.0 vshard clusters. This patch fixes the issue. Now the code uses name as key, if corresponding mode is enabled, and uuid otherwise. Patch doesn't cover `select_old` since it runs only on pre-3.0 Tarantool. Unfortunately, code relies on vshard internals since now there is no other way [1]. This patch covers new mode support for readview code as well. It likely was broken before this patch even if UUIDs were provided. 1. tarantool/vshard#460 Follows #404 Closes #407
DifferentialOrange
added a commit
that referenced
this issue
Feb 5, 2024
Overview This release introduces compatibility with several Tarantool 3 + vshard 0.1.25 features, as well as critical scan fix. Fixed * Compatibility with vshard configuration if UUIDs are omitted (#407). * Compatibility with automatic master discovery in vshard (#409). * Secondary conditions for index operands with operations `>=`, `<=`, `>`, `<` no longer cause missing part of the actual result for scan operations (`crud.select`, `crud.pairs`, `crud.count`, `readview:select`, `readview:pairs`) (#418).
Merged
DifferentialOrange
added a commit
that referenced
this issue
Feb 5, 2024
Overview This release introduces compatibility with several Tarantool 3 + vshard 0.1.25 features, as well as critical scan fix. Fixed * Compatibility with vshard configuration if UUIDs are omitted (#407). * Compatibility with automatic master discovery in vshard (#409). * Secondary conditions for index operands with operations `>=`, `<=`, `>`, `<` no longer cause missing part of the actual result for scan operations (`crud.select`, `crud.pairs`, `crud.count`, `readview:select`, `readview:pairs`) (#418).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assume, we have cluster config:
router.lua:
storage.lua:
instances.yml (is required to start with tt):
Check in logs, what happened with stopped instances:
vshard config (which was applied by tarantool itself):
Here is how tarantool builds vshard config: https://github.com/tarantool/tarantool/blob/57c1f625ffb280aea950030962cff104b3f3a47d/src/box/lua/config/configdata.lua#L144-L231
The text was updated successfully, but these errors were encountered: