New checks types #44
Merged
New checks types #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
DifferentialOrange/migrate-to-luatest
to
master
January 16, 2023 07:21
DifferentialOrange
force-pushed
the
DifferentialOrange/new-checks-types
branch
2 times, most recently
from
4fb6d0f to
d167608
Compare
|
Rebased, ready for review |
Merged
Totktonada
reviewed
Jan 16, 2023
Totktonada
reviewed
Jan 16, 2023
Change Tarantool type checkers builder to add checkers if there are expected modules. Part of tarantool/tarantool#7726
Support error type checks for box.error objects [1] (can be explicitly created in Tarantool Lua scripts since 2.4.1). 1. tarantool/tarantool#4398 Part of tarantool/tarantool#7726
Support datetime type checks [1] (added in Tarantool 2.10.0). 1. tarantool/tarantool#5941 Part of tarantool/tarantool#7726
Support interval type checks [1] (added in Tarantool 2.10.0). 1. tarantool/tarantool#5941 Part of tarantool/tarantool#7726
DifferentialOrange
force-pushed
the
DifferentialOrange/new-checks-types
branch
from
d167608 to
a501cc5
Compare
yngvar-antonsson
approved these changes
Jan 16, 2023
|
Thank you for the patch! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-health: rework Tarantool type checkers
Change Tarantool type checkers builder to add checkers if there are expected modules.
Part of tarantool/tarantool#7726
feature: support error type
Support error type checks for box.error objects [1] (can be explicitly created in Tarantool Lua scripts since 2.4.1).
Part of tarantool/tarantool#7726
feature: support datetime type
Support datetime type checks [1] (added in Tarantool 2.10.0).
Part of tarantool/tarantool#7726
feature: support interval type
Support interval type checks [1] (added in Tarantool 2.10.0).
Part of tarantool/tarantool#7726