Embedding preparation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
4 times, most recently
from
eb40948 to
ae752bd
Compare
This was referenced Jan 11, 2023
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
2 times, most recently
from
703f839 to
ebd2fbe
Compare
DifferentialOrange
changed the base branch from
master
to
DifferentialOrange/new-checks-types
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
2 times, most recently
from
dcab163 to
092d931
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/new-checks-types
branch
from
d167608 to
a501cc5
Compare
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
from
092d931 to
0ae478b
Compare
Base automatically changed from
DifferentialOrange/new-checks-types
to
master
January 16, 2023 20:04
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
from
0ae478b to
ddf0836
Compare
yngvar-antonsson
approved these changes
Jan 17, 2023
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
3 times, most recently
from
a14633e to
27713d6
Compare
|
I decided to stick to the os environment switch since it is easier to set up that UPD: the decision was changed. |
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
from
27713d6 to
7a35c5b
Compare
ligurio
approved these changes
Feb 6, 2023
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
from
7a35c5b to
29c4f0d
Compare
ligurio
approved these changes
Feb 7, 2023
luatest expect tests to be stored in test folder. Part of tarantool/tarantool#7726
After embedding checks to the core binary, plain require('checks') will
return embedded module. So it won't be possible to run repository module
tests (in reusable_testing or with repository CI) with repository code
until it overloads build-in code. Until [1] is resolved there are no
any other way to deal with it. (And even after [1] would be resolved,
it may worth to leave it like this to support older versions with
built-in checks.) test/helper.lua is automatically required by luatest
before any run.
1. tarantool/tarantool#7774
Part of tarantool/tarantool#7726
DifferentialOrange
force-pushed
the
DifferentialOrange/tarantool-embed-followups
branch
from
29c4f0d to
41c8659
Compare
ligurio
approved these changes
Feb 8, 2023
DifferentialOrange
deleted the
DifferentialOrange/tarantool-embed-followups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: do not run on built-in
After embedding checks to the core binary, plain
require('checks')will return embedded module. So it won't be possible to run repository module tests (in reusable_testing or with repository CI) with repository code until it overloads build-in code. Until [1] is resolved there are no any other way to deal with it. (And even after [1] would be resolved, it may worth to leave it like this to support older versions with built-in checks.)Part of tarantool/tarantool#7726