points text required to optional #1209

tallytalwar · 2017-01-06T19:39:50Z

Depends on #1208

To match modified behavior in JS and the documentation, the usage of points:text:required to points:text:optional.

matteblair · 2017-01-06T20:05:41Z

One change at a time please 😇

tallytalwar · 2017-01-06T20:09:55Z

Ohh other changes (scene file changes are coming from #1208). This only has one change (5c086c1), but is based off update-scene-file branch.

inverts the behavior (previous required: true is now optional: false)

tallytalwar · 2017-01-09T20:56:11Z

Just updated with master, will merge once circle and travis are done.

tallytalwar added ready for review scene spec labels Jan 6, 2017

tallytalwar requested a review from karimnaaji January 6, 2017 19:39

tallytalwar force-pushed the icons-text-required-TO-optional branch from 5c086c1 to c109a37 Compare January 9, 2017 19:28

karimnaaji approved these changes Jan 9, 2017

View reviewed changes

Change points:text:required to points:text:optional

80b62f0

inverts the behavior (previous required: true is now optional: false)

tallytalwar force-pushed the icons-text-required-TO-optional branch from c109a37 to 80b62f0 Compare January 9, 2017 20:55

tallytalwar merged commit db73248 into master Jan 9, 2017

tallytalwar deleted the icons-text-required-TO-optional branch January 9, 2017 21:12

Provide feedback