Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scene file to match more closely with JS #1208

Merged
merged 3 commits into from
Jan 9, 2017
Merged

Conversation

tallytalwar
Copy link
Member

@tallytalwar tallytalwar commented Jan 6, 2017

  • has so much more info now.
  • also one MAJOR change is the use of the v1 tile urls

Few differences from current JS scene file:

  1. Use of px2 is commented out as its not supported in ES yet!
  2. Label/Poi rendering uses transitions in ES
  3. Road labels in ES show off repeat distance and repeat group (Probably JS should also use this)
  4. some rearrangement of visible parameter is done in ES. (moved visible to draw group instead of layer property).

@tallytalwar tallytalwar requested a review from karimnaaji January 6, 2017 18:46
@tallytalwar tallytalwar force-pushed the update-scene-file branch 2 times, most recently from 99e794b to 6f21ca5 Compare January 6, 2017 18:58
- has so much more info now.
- also one MAJOR change is the use of the v1 tile urls
@@ -6,10 +6,10 @@ fonts:
url: https://fonts.gstatic.com/s/montserrat/v7/zhcz-_WihjSQC0oHJ9TCYL3hpw3pgy2gAi-Ip7WPMi0.woff
Open Sans:
- weight: 300
url: fonts/open sans-300normal.ttf
url: https://github.com/tangrams/bubble-wrap/raw/gh-pages/fonts/OpenSans-Regular.woff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more stable URL we can use for these? Google Fonts maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Mapzen house styles we usually add a comment with the remote URL and follow that with an uncommented local resources:

#url: https://fonts.gstatic.com/s/montserrat.woff
url: fonts/montserrat.woff

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggest including a local copy of the resource in your repo, too)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been trying to not include fonts in tangram es repo..

We can probably point this to some proper url, but this is a just a copy of what tangram JS has in its demo scene.

url: fonts/open sans-300normal.ttf
- weight: 300
- weight: 400
url: http://fonts.gstatic.com/s/opensans/v13/IgZJs4-7SA1XX_edsoXWog.ttf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there woff files available? Wouldn't truetype files be much larger?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are quite simple fonts with only a few hundreds kilobytes in it (at most 200k), there's not much gain we could have. Finding other formats that woff2 is quite tedious since they don't propose it anymore on their website https://fonts.google.com/. I had to use an API key and download a full list of their fonts with TTF formats from https://www.googleapis.com/webfonts/v1/webfonts:

GoogleFonts.txt

@karimnaaji karimnaaji merged commit a06b070 into master Jan 9, 2017
@karimnaaji karimnaaji deleted the update-scene-file branch January 9, 2017 18:48
@tallytalwar tallytalwar mentioned this pull request Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants