-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scene file to match more closely with JS #1208
Conversation
99e794b
to
6f21ca5
Compare
- has so much more info now. - also one MAJOR change is the use of the v1 tile urls
d9ea08b
to
4d8f53d
Compare
@@ -6,10 +6,10 @@ fonts: | |||
url: https://fonts.gstatic.com/s/montserrat/v7/zhcz-_WihjSQC0oHJ9TCYL3hpw3pgy2gAi-Ip7WPMi0.woff | |||
Open Sans: | |||
- weight: 300 | |||
url: fonts/open sans-300normal.ttf | |||
url: https://github.com/tangrams/bubble-wrap/raw/gh-pages/fonts/OpenSans-Regular.woff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more stable URL we can use for these? Google Fonts maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Mapzen house styles we usually add a comment with the remote URL and follow that with an uncommented local resources:
#url: https://fonts.gstatic.com/s/montserrat.woff
url: fonts/montserrat.woff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(suggest including a local copy of the resource in your repo, too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been trying to not include fonts in tangram es repo..
We can probably point this to some proper url, but this is a just a copy of what tangram JS has in its demo scene.
1a382fe
to
2c256ba
Compare
2c256ba
to
d949c5c
Compare
url: fonts/open sans-300normal.ttf | ||
- weight: 300 | ||
- weight: 400 | ||
url: http://fonts.gstatic.com/s/opensans/v13/IgZJs4-7SA1XX_edsoXWog.ttf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there woff files available? Wouldn't truetype files be much larger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are quite simple fonts with only a few hundreds kilobytes in it (at most 200k), there's not much gain we could have. Finding other formats that woff2
is quite tedious since they don't propose it anymore on their website https://fonts.google.com/. I had to use an API key and download a full list of their fonts with TTF formats from https://www.googleapis.com/webfonts/v1/webfonts:
Few differences from current JS scene file:
px2
is commented out as its not supported in ES yet!visible
parameter is done in ES. (moved visible to draw group instead of layer property).