Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ark circom #292

Merged
merged 65 commits into from
Mar 1, 2023
Merged

ark circom #292

merged 65 commits into from
Mar 1, 2023

Conversation

akileshtangella
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

drewstone and others added 30 commits December 15, 2022 12:08
@drewstone
Bump all deps to 0.9.34 and start working on compilation
ee473d3
@drewstone
Building the runtime
57dae40
@drewstone
Add feature
fd4feec
cargo check passes
2b76ee2
wip
859bfaf
@drewstone
Remove protocol-substrate-fixtures path and submodule
3f3304a
try workaround - wrapper types
41ed679
@drewstone
Fmt
be76020
@drewstone
Use versioned paths of substrate primitives in the client test
c222ee6
@drewstone
Add consistent wrapping + instances for circom tests
d3bbc37
@drewstone
Fix error issue with circom work
a37bb9e
@drewstone
Add circom verifier to vanchor mock
bad23b2
@drewstone
Add circom tests file
1c315ef
@drewstone
More work on circom integration
95453e5
update to 0.9.36 - wip
e8a78f9
wip
468e033
compiling with cargo check --tests
e5467be
@drewstone
Get proving started, failing verification
be9178a
update dep
cb68766
@drewstone
Working through circom proving
b401299
@drewstone
Satisfy the circuit
b1bd56a
@drewstone
Updates, get native verification with random parameters working
9ed4c36
@drewstone
Fmt
ede2e84
@drewstone
Merge branch 'main' into drew/wrapping-circom-updates
01dba1f
@drewstone
Merge 0.9.36
f2279c9
@drewstone
Ups
4b61970
@drewstone
Using random params
3f42618
@shekohex
no need for custom impl of VerifiyingKey
2dc38e0
@drewstone
Merge main
1f0d9dc
@drewstone
Fmt
1a7874d
@dutterbutter
Copy link
Contributor

dutterbutter commented Feb 24, 2023 •
edited by akileshtangella
Loading

@saiakilesh I resolved your issue with fetching fixtures, and provided an easy script ./scripts/fetch-fixtures.sh for future reference. I also resolved the formatting issues and the incorrect file paths to the fixtures.

The CI will still fail as you have not properly implemented the trait pallet::Config<pallet_balances::Instance1> is not implemented for mock::Test in pallets/mixer/src/tests.rs:. To resolve the issue refer to implementation of Instance1 in vanchor pallet.

Other TODOs on this PR I noticed:

  • Please update the README to remove dvc pull command and reference the above mentioned fetch fixtures script
  • Remove the .vscode directory unless this was intentional

@drewstone drewstone merged commit b7771fd into main Mar 1, 2023
@drewstone drewstone deleted the akilesh/ark-circom branch March 1, 2023 12:57
@dutterbutter dutterbutter mentioned this pull request Mar 1, 2023
Merged
akileshtangella added a commit that referenced this pull request Mar 1, 2023
@akileshtangella
Revert "ark circom (#292)"
b1283ed 
This reverts commit b7771fd.
@akileshtangella akileshtangella mentioned this pull request Mar 1, 2023
Closed
@akileshtangella akileshtangella restored the akilesh/ark-circom branch March 1, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akileshtangella @dutterbutter @drewstone @shekohex