Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates and fixes Dockerfile and build #294

Merged
merged 9 commits into from
Mar 2, 2023
Merged

chore: updates and fixes Dockerfile and build #294

merged 9 commits into from
Mar 2, 2023

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Mar 1, 2023 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Updated Standalone.Dockerfile to make use of fixtures script and reduces base image size
  • Updates check.yml file to run build, format, and test in parallel
  • Fixes build issue

Reference issue to close (if applicable)

Closes

@dutterbutter dutterbutter changed the title chore: Updates and fixes Dockerfile chore: updates and fixes Dockerfile Mar 1, 2023
@dutterbutter dutterbutter marked this pull request as ready for review March 1, 2023 21:24
@dutterbutter dutterbutter changed the title chore: updates and fixes Dockerfile chore: updates and fixes Dockerfile and build Mar 1, 2023
@dutterbutter dutterbutter added the needs review 👓 Pull request needs a review label Mar 1, 2023
drewstone
drewstone approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@drewstone drewstone merged commit 07bc1de into main Mar 2, 2023
@drewstone drewstone deleted the db/fix-docker branch March 2, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@akileshtangella akileshtangella Awaiting requested review from akileshtangella

Assignees
No one assigned
Labels
needs review 👓 Pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dutterbutter @drewstone @akileshtangella