fix ref element #249
Merged
fix ref element #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is probably a better way to do this, the idea is that we apply a ref to the component. However by default for html components `yourRef.value` will be the underlying DOM node. However if you pass the ref to another component, the actual DOM node will be located at `yourRef.value.$el`. Fixes: #21
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/103ddx65p headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/5y2sstjbl |
This was referenced Feb 19, 2021
Merged
Merged
This was referenced Mar 15, 2021
Merged
RobinMalfait
added a commit
that referenced
this pull request
Mar 22, 2021
* add small dom utility to resolve the dom node from a ref * use dom() to resolve underlying DOM node There is probably a better way to do this, the idea is that we apply a ref to the component. However by default for html components `yourRef.value` will be the underlying DOM node. However if you pass the ref to another component, the actual DOM node will be located at `yourRef.value.$el`. Fixes: #21 * update changelog
RobinMalfait
added a commit
that referenced
this pull request
Mar 26, 2021
* add small dom utility to resolve the dom node from a ref * use dom() to resolve underlying DOM node There is probably a better way to do this, the idea is that we apply a ref to the component. However by default for html components `yourRef.value` will be the underlying DOM node. However if you pass the ref to another component, the actual DOM node will be located at `yourRef.value.$el`. Fixes: #21 * update changelog
RobinMalfait
added a commit
that referenced
this pull request
Apr 2, 2021
* add small dom utility to resolve the dom node from a ref * use dom() to resolve underlying DOM node There is probably a better way to do this, the idea is that we apply a ref to the component. However by default for html components `yourRef.value` will be the underlying DOM node. However if you pass the ref to another component, the actual DOM node will be located at `yourRef.value.$el`. Fixes: #21 * update changelog
RobinMalfait
added a commit
that referenced
this pull request
Apr 2, 2021
* add small dom utility to resolve the dom node from a ref * use dom() to resolve underlying DOM node There is probably a better way to do this, the idea is that we apply a ref to the component. However by default for html components `yourRef.value` will be the underlying DOM node. However if you pass the ref to another component, the actual DOM node will be located at `yourRef.value.$el`. Fixes: #21 * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #21