Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next batch of Vue components #282

Merged
merged 48 commits into from
Apr 4, 2021
Merged

Next batch of Vue components #282

merged 48 commits into from
Apr 4, 2021

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Mar 16, 2021 •
edited
Loading

New Vue components:

  • Dialog
    • DialogOverlay
    • DialogTitle
    • DialogDescription
  • Disclosure
    • DisclosureButton
    • DisclosurePanel
  • FocusTrap
  • Portal
    • PortalGroup
  • Popover
    • PopoverButton
    • PopoverOverlay
    • PopoverPanel
    • PopoverGroup
  • RadioGroup
    • RadioGroupOption
    • RadioGroupLabel
    • RadioGroupDescription
  • Update changelog
  • General cleanup

@vercel
Copy link

vercel bot commented Mar 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

headlessui-react – ./packages/@headlessui-react

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/F7Z1tcSND1pzoA34Wrye1zqHvYim
✅ Preview: https://headlessui-react-git-more-components-tailwindlabs.vercel.app

headlessui-vue – ./packages/@headlessui-vue

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/2yN7qRkZohQUEvBHJtSDHGPwrTdh
✅ Preview: https://headlessui-vue-git-more-components-tailwindlabs.vercel.app

@RobinMalfait RobinMalfait changed the base branch from main to develop March 16, 2021 15:24
@RobinMalfait
improve type in test
6d7aca5
@RobinMalfait
cleanup internal Dialog Description
08919ef 
We have a low level Description component abstraction that can be used
instead of the Dialog specifiction Description.
@RobinMalfait
refactor raw window events to a shared useWindowEvent
ef40ae7
@RobinMalfait
passthrough prop bag via context for abstract Description
1fd793b 
The Description component is a generic low level component that is
re-used. This causes an issue that the render prop "bag"/"slot" doesn't
contain the data from let's say a Dialog component.

This commit will ensure that you can specify a bag (React) and slot
(Vue) on the DescriptionProvider, so that the Description component can
read it from the context.
@RobinMalfait
improve render function in React
51e0788 
These contain a few changes that are purely internal changes. Nothing
changes / breaks in the public API of the components.

- Instead of using multiple arguments in your `render()` functions, we now
use an object.
- `propsBag` / `bag` is renamed to `slot`.
- We also provide a `name` to the render function, so that we can use
  that to improve error messages.
@RobinMalfait RobinMalfait merged commit 6f8225c into develop Apr 4, 2021
@RobinMalfait RobinMalfait deleted the more-components branch April 4, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinMalfait