fix object assign name #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to read a custom `displayName`, and we can default to a `name`. React Devtools will still be able to read this information. Fixes: #246
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/ot5a5xoig headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/qlh7bfccs |
This was referenced Feb 23, 2021
Merged
Merged
This was referenced Mar 15, 2021
Merged
RobinMalfait
added a commit
that referenced
this pull request
Mar 22, 2021
This allows us to read a custom `displayName`, and we can default to a `name`. React Devtools will still be able to read this information. Fixes: #246
RobinMalfait
added a commit
that referenced
this pull request
Mar 26, 2021
This allows us to read a custom `displayName`, and we can default to a `name`. React Devtools will still be able to read this information. Fixes: #246
RobinMalfait
added a commit
that referenced
this pull request
Apr 2, 2021
This allows us to read a custom `displayName`, and we can default to a `name`. React Devtools will still be able to read this information. Fixes: #246
RobinMalfait
added a commit
that referenced
this pull request
Apr 2, 2021
This allows us to read a custom `displayName`, and we can default to a `name`. React Devtools will still be able to read this information. Fixes: #246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
forwardRef, utility we loose the information likeComponent.name, to fix this I added thenameto the result of theforwardRef. That said, this causes build errors in certain scenario's (see #246).This PR will fix that by applying
displayNameinstead.