Fix nested Popover
components not opening
#2293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in the React version where nested popovers don't work anymore.
The issue was the check to know whether we are in a
Popover.Panel
or not. We also have to check ifwe are in the correct panel (this part is important for nested
Popover
s, and was removed).Added a test to make sure this won't regress anymore. Also added the same test to the Vue version to
protect against regressions there as well.
Fixes: #2285
Fixes: #2292