Move aria-multiselectable to [role=listbox] in the Combobox component
#2271
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/issue-2270
branch
from
2a01070 to
62227a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a misplacement of the
aria-multiselectablearia attribute.I couldn't find evidence why we originally put it on the
[role="combobox"]element, but I think this was because we started from theListboxcomponent as a starting point.I also couldn't find evidence why we should put it on the
[role="combobox"]itself. Looking at the best practices they mention thearia-multiselectableattribute, and that it should be used in combination with someroles, such as thelistboxrole. https://w3c.github.io/aria/#aria-multiselectableTesting it in the browser with VoiceOver: This does indeed improve the information that you get from VO. Luckily all other functionality is exactly the same.
Fixes: #2270