Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox: Wrong placement of aria-multiselectable attribute? ARIA attribute is not allowed: aria-multiselectable="true" #2270

Closed
RIP21 opened this issue Feb 10, 2023 · 1 comment · Fixed by #2271
Assignees

Comments

@RIP21
Copy link

RIP21 commented Feb 10, 2023

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

1.7.10

What browser are you using?
Chrome

Reproduction URL

Screenshot:
CleanShot 2023-02-10 at 14 36 54@2x

The multi-select implementation I have, for reference, is here:
Codesandbox

Describe your issue

As per MDN aria-multiselectable="true" should be set on ul element (e.g. the container of the options not on the input). a11y checks (a11y-addon) of the Storybook complains about it.

I'm, by no means, an expert in ARIA attributes, but just noted this violation and I think it makes sense to report it.

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed by #2271, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/react@insiders.
  • npm install @headlessui/vue@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants