Re-expose el
#1230
Merged
Re-expose el
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to expose a custom `el` when we used a `setup()` and `render()` function. But due to some refactors we got now only have a `setup()` and no more `el`. This causes some problems if people relied on the exposed `el`. In this PR will make sure to re-expose the `el` that we used to expose. The only issue is, now that we manually expose a list, we have to re-expose the `$el` internal as well.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/CmGNdwYKBP896WCzHWhoRv99vm93 headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/4SK7DELT8GhHVegWQoCfx3iX3WRj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to expose a custom
elwhen we used asetup()andrender()function. But due to some refactors we got now only have a
setup()andno more
el. This causes some problems if people relied on the exposedel.In this PR will make sure to re-expose the
elthat we used to expose.The only issue is, now that we manually expose a list, we have to
re-expose the
$elinternal as well.Fixes: #1222