Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Items with Popper modifications stopped working #1222

Closed
neoighodaro opened this issue Mar 9, 2022 · 1 comment · Fixed by #1230
Closed

Menu Items with Popper modifications stopped working #1222

neoighodaro opened this issue Mar 9, 2022 · 1 comment · Fixed by #1230
Assignees

Comments

@neoighodaro
Copy link

neoighodaro commented Mar 9, 2022

What package within Headless UI are you using?
@headlessui/vue

What version of that package are you using?
v1.5.0

What browser are you using?
Chrome

Reproduction
Run Playground Example (menu items with Popper): packages/playground-vue

Describe your issue
Previously, the Popper modifier was working correctly using the hook but recently it does not work anymore. Just a minor investigation shows that line 16 and 17 do not return HTMLElement anymore. So the createPopper call is not made at all.

Not entirely sure what to report it as since the actual component seems to work, but the example does not work anymore, thus no easy (or documented) way to modify the underlying Popper. Perhaps it just needs to be updated.

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed by #1230, and will be available in the next release.

You can already try it using npm install @headlessui/vue@insiders or yarn add @headlessui/vue@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants