fix: filter out tailcall specific directives #2935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 263 263
Lines 26252 26261 +9
=======================================
+ Hits 22934 22943 +9
Misses 3318 3318 ☔ View full report in Codecov by Sentry. |
amitksingh1490
force-pushed
the
fix/filter-tc-specific-directives
branch
from
ddf22e3 to
1d7353f
Compare
meskill
requested changes
Sep 30, 2024
| @@ -96,7 +114,7 @@ pub fn compile_service(config: &ConfigModule) -> Valid<IR, String> { | |||
|
|
|||
| fn filter_conflicting_directives(sd: ServiceDocument) -> ServiceDocument { | |||
| fn filter_directive(directive_name: &str) -> bool { | |||
| directive_name != "link" | |||
| FEDERATION_DIRECTIVES.iter().any(|d| *d == directive_name) | |||
There was a problem hiding this comment.
Suggested change
| FEDERATION_DIRECTIVES.iter().any(|d| *d == directive_name) | |
| FEDERATION_DIRECTIVES.contains(directive_name) |
| @@ -13,6 +15,22 @@ use crate::core::try_fold::TryFold; | |||
| use crate::core::valid::{Valid, Validator}; | |||
| use crate::core::{config, Type}; | |||
|
|
|||
| // ref: https://www.apollographql.com/docs/federation/federated-schemas/federated-directives | |||
| const FEDERATION_DIRECTIVES: &[&str] = &[ | |||
There was a problem hiding this comment.
we have a similar list of federation directives here https://github.com/tailcallhq/tailcall/pull/2935/files#diff-f40f5478a0ee614381f25d37362c9c9c7779df174a375a166cf70e3e392e5a5dR109 can we reuse the definition?
|
The implementation for generating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference(s):
Fixes #2929