Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide tailcall directives from _service #2929

Closed
tusharmath opened this issue Sep 28, 2024 · 1 comment · Fixed by #2930
Closed

hide tailcall directives from _service #2929

tusharmath opened this issue Sep 28, 2024 · 1 comment · Fixed by #2930
Assignees
@meskill

Comments

@tusharmath
Copy link
Contributor

Currently all the tailcall directives are outputted in the _service call. We should only expose the final client SDL with the federation specific directives.

Why?
Because of the current implementation everytime Config changes, the federation spec tests also need to be updated.

cc: @meskill
@ssddOnTop ssddOnTop self-assigned this Sep 28, 2024
@ssddOnTop ssddOnTop mentioned this issue Sep 28, 2024
Merged
@ssddOnTop ssddOnTop mentioned this issue Sep 29, 2024
Closed
@tusharmath tusharmath reopened this Sep 30, 2024
@algora-pbc algora-pbc bot removed the 💎 Bounty label Sep 30, 2024
@meskill meskill assigned meskill and unassigned ssddOnTop Oct 1, 2024
@meskill
Copy link
Contributor

meskill commented Oct 7, 2024

fixed by #2894

@meskill meskill closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meskill meskill

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tusharmath @meskill @ssddOnTop