Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpc): allow users to pass value along with mustache template #2383

Merged
merged 7 commits into from
Jul 9, 2024
Merged

fix(grpc): allow users to pass value along with mustache template #2383

merged 7 commits into from
Jul 9, 2024

Conversation

ssddOnTop
Copy link
Member

/claim #2381

@algora-pbc algora-pbc bot mentioned this pull request Jul 9, 2024
Closed
2 tasks
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jul 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.37%. Comparing base (e90f961) to head (f4a7566).

Files Patch % Lines
src/core/blueprint/mustache.rs 80.00% 1 Missing ⚠️
src/core/grpc/request_template.rs 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2383   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         242      242           
  Lines       22494    22517   +23     
=======================================
+ Hits        19654    19675   +21     
- Misses       2840     2842    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssddOnTop ssddOnTop marked this pull request as draft July 9, 2024 08:40
@ssddOnTop ssddOnTop marked this pull request as ready for review July 9, 2024 09:02
@tusharmath tusharmath changed the title chore(grpc): allow users to pass value along with mustache template fix(grpc): allow users to pass value along with mustache template Jul 9, 2024
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Jul 9, 2024
@tusharmath tusharmath enabled auto-merge (squash) July 9, 2024 12:04
@tusharmath tusharmath merged commit afde464 into main Jul 9, 2024
29 of 30 checks passed
@tusharmath tusharmath deleted the chore/grpc-body-to-bal branch July 9, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssddOnTop @tusharmath