Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong type for the body parameter of the grpc directive #2381

Closed
2 tasks done
nekinie opened this issue Jul 9, 2024 · 8 comments
Closed
2 tasks done

wrong type for the body parameter of the grpc directive #2381

nekinie opened this issue Jul 9, 2024 · 8 comments
Labels

Comments

@nekinie
Copy link

nekinie commented Jul 9, 2024

Prerequisites

  • I have checked the existing issues to ensure this is not a duplicate.
  • I am running the latest version of Tailcall.

Describe the bug

The type for the body parameter of the GRPC directive is string, but the comment around its decleration indicates that static objects should work. I beleve the type should be JSON to support flat objects in the same way that the args parameter for the call directive.

https://github.com/tailcallhq/tailcall/blob/main/generated/.tailcallrc.graphql#L112

@tusharmath tusharmath added the type: bug Something isn't working. label Jul 9, 2024
@tusharmath
Copy link
Contributor

/bounty 100$

Copy link

algora-pbc bot commented Jul 9, 2024

## 💎 $100 bounty • Tailcall Inc.

### Steps to solve:
1. Start working: Comment /attempt #2381 with your implementation plan
2. Submit work: Create a pull request including /claim #2381 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.
💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🟢 @ssddOnTop Jul 9, 2024, 7:32:36 AM #2383

@ssddOnTop
Copy link
Member

ssddOnTop commented Jul 9, 2024

/attempt #2381

Algora profile Completed bounties Tech Active attempts Options
@ssddOnTop 52 tailcallhq bounties
Rust, Java,
C & more
Cancel attempt

@tusharmath
Copy link
Contributor

tusharmath commented Jul 9, 2024

Thanks @nekinie you are right, I think this is a quick fix. BTW have you checked out our auto-generation guide — https://tailcall.run/docs/graphql-configuration-generation-with-tailcall/

It should reduce your GraphQL onboarding time drastically!

Copy link

algora-pbc bot commented Jul 9, 2024

💡 @ssddOnTop submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Jul 9, 2024

🎉🎈 @ssddOnTop has been awarded $100! 🎈🎊

@tusharmath
Copy link
Contributor

fixed in #2383

@nekinie
Copy link
Author

nekinie commented Jul 10, 2024

I gave this a test today and everything looks great, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants