Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Icons add new directive #6053

Merged
merged 5 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@
<p>
<tui-badge
*ngIf="contentType === 'with icon'"
iconLeft="tuiIconCheck"
[appearance]="appearance"
[dot]="dot"
[size]="size"
>
<tui-icon icon="tuiIconCheck"></tui-icon>
<div tuiFade>Taiga UI</div>
</tui-badge>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,36 @@
<h4 class="tui-space_vertical-1">Value with icon</h4>
<tui-badge
appearance="primary"
iconLeft="tuiIconBox"
size="xl"
>
<tui-icon icon="tuiIconBox"></tui-icon>
x-large
</tui-badge>

<tui-badge
appearance="primary"
iconLeft="tuiIconBox"
size="l"
class="tui-space_left-1"
>
<tui-icon icon="tuiIconBox"></tui-icon>
large
</tui-badge>

<tui-badge
appearance="primary"
iconLeft="tuiIconBox"
size="m"
class="tui-space_left-1"
>
<tui-icon icon="tuiIconBox"></tui-icon>
medium
</tui-badge>

<tui-badge
appearance="primary"
iconLeft="tuiIconBox"
size="s"
class="tui-space_left-1"
>
<tui-icon icon="tuiIconBox"></tui-icon>
small
</tui-badge>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

<tui-badge
appearance="accent"
iconLeft="tuiIconBox"
size="l"
class="badge tui-space_top-3"
>
<tui-icon icon="tuiIconBox"></tui-icon>
<div class="t-ellipsis">Very long value in badge</div>
</tui-badge>
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<tui-badge
appearance="custom"
iconLeft="tuiIconLock"
size="xl"
class="custom-1"
>
<tui-icon icon="tuiIconLock"></tui-icon>
10 000 000 $
</tui-badge>

Expand Down
4 changes: 3 additions & 1 deletion projects/experimental/components/badge/badge.module.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import {NgModule} from '@angular/core';
import {TuiIconsDirective, TuiIconsModule} from '@taiga-ui/experimental/directives/icons';

import {TuiBadgeComponent} from './badge.component';
import {TuiBadgeDirective} from './badge.directive';

@NgModule({
imports: [TuiIconsModule],
declarations: [TuiBadgeComponent, TuiBadgeDirective],
exports: [TuiBadgeDirective],
exports: [TuiBadgeDirective, TuiIconsDirective],
})
export class TuiBadgeModule {}
7 changes: 4 additions & 3 deletions projects/experimental/components/badge/badge.style.less
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ tui-badge,
}

> tui-svg,
> tui-icon {
width: var(--t-icon-size) !important;
height: var(--t-icon-size) !important;
> tui-icon,
&[tuiIcons]:before,
&[tuiIcons]:after {
font-size: var(--t-icon-size) !important;
}

&[data-appearance='error'] {
Expand Down
14 changes: 1 addition & 13 deletions projects/experimental/components/button/button.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ import {
Input,
ViewEncapsulation,
} from '@angular/core';
import {TuiDirectiveStylesService, TuiStringHandler} from '@taiga-ui/cdk';
import {TuiDirectiveStylesService} from '@taiga-ui/cdk';
import {MODE_PROVIDER, TUI_MODE, TuiBrightness} from '@taiga-ui/core';
import {TUI_ICON_RESOLVER} from '@taiga-ui/experimental/tokens';
import {Observable} from 'rxjs';

import {TUI_BUTTON_OPTIONS, TuiButtonOptions} from './button.options';
Expand All @@ -30,10 +29,6 @@ export class TuiButtonStylesComponent {}
host: {
tuiButtonNew: '',
tuiAppearance: '',
'[class._icon-left]': 'iconLeft',
'[class._icon-right]': 'iconRight',
'[style.--t-mask-left]': '"url(" + resolver(iconLeft) + ")"',
'[style.--t-mask-right]': '"url(" + resolver(iconRight) + ")"',
'[attr.data-size]': 'size',
'[attr.data-appearance]': 'appearance',
'($.data-mode.attr)': 'mode$',
Expand All @@ -46,14 +41,7 @@ export class TuiButtonDirective {
@Input()
appearance = this.options.appearance;

@Input()
iconLeft = '';

@Input()
iconRight = '';

constructor(
@Inject(TUI_ICON_RESOLVER) readonly resolver: TuiStringHandler<string>,
@Inject(TUI_BUTTON_OPTIONS) private readonly options: TuiButtonOptions,
@Inject(TUI_MODE) readonly mode$: Observable<TuiBrightness | null>,
@Inject(TuiDirectiveStylesService) directiveStyles: TuiDirectiveStylesService,
Expand Down
5 changes: 3 additions & 2 deletions projects/experimental/components/button/button.module.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import {CommonModule} from '@angular/common';
import {NgModule} from '@angular/core';
import {TuiLoaderModule, TuiSvgModule} from '@taiga-ui/core';
import {TuiIconsDirective, TuiIconsModule} from '@taiga-ui/experimental/directives/icons';

import {TuiButtonComponent} from './button.component';
import {TuiButtonDirective, TuiButtonStylesComponent} from './button.directive';

@NgModule({
imports: [CommonModule, TuiSvgModule, TuiLoaderModule],
imports: [CommonModule, TuiSvgModule, TuiLoaderModule, TuiIconsModule],
declarations: [TuiButtonComponent, TuiButtonDirective, TuiButtonStylesComponent],
exports: [TuiButtonComponent, TuiButtonDirective],
exports: [TuiButtonComponent, TuiButtonDirective, TuiIconsDirective],
})
export class TuiButtonModule {}
27 changes: 4 additions & 23 deletions projects/experimental/components/button/button.style.less
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
tui-svg,
tui-icon,
&:before {
width: 1rem;
font-size: 1rem;
}
}

Expand All @@ -48,8 +48,7 @@
tui-svg,
tui-icon,
&:not([tuiIconButton][data-appearance='icon']):before {
width: 1rem;
height: 1rem;
font-size: 1rem;
}
}

Expand Down Expand Up @@ -101,28 +100,10 @@
}
}

&._icon-left:before {
content: '';
}

&._icon-right:after {
content: '';
}

&:before {
width: 1.5rem;
height: 1.5rem;
background: currentColor;
mask: var(--t-mask-left) no-repeat center/contain;
}

&:after {
width: 1rem;
height: 1rem;
background: currentColor;
&[tuiIcons]:after {
font-size: 1rem;
margin-inline-start: 0.125rem;
margin-inline-end: -0.125rem;
mask: var(--t-mask-right) no-repeat center/contain;
}
}

Expand Down
5 changes: 3 additions & 2 deletions projects/experimental/components/icon/icon.style.less
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
:host {
position: relative;
display: inline-block;
width: 1.5rem;
height: 1.5rem;
width: 1em;
height: 1em;
font-size: 1.5rem;
vertical-align: middle;

&._duo {
Expand Down
12 changes: 12 additions & 0 deletions projects/experimental/directives/icons/icons.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import {ChangeDetectionStrategy, Component, ViewEncapsulation} from '@angular/core';

@Component({
template: '',
styleUrls: ['./icons.styles.less'],
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
class: 'tui-icons',
},
})
export class TuiIconsComponent {}
32 changes: 32 additions & 0 deletions projects/experimental/directives/icons/icons.directive.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import {Directive, Inject, Input} from '@angular/core';
import {TuiDirectiveStylesService, TuiStringHandler} from '@taiga-ui/cdk';
import {TUI_ICON_RESOLVER} from '@taiga-ui/experimental/tokens';

import {TuiIconsComponent} from './icons.component';

// TODO: Turn into a hostDirective in 4.0
@Directive({
selector:
'[iconLeft]:is(button,tui-badge),[iconRight]:is(button,tui-badge),[tuiBadge][iconLeft],[tuiBadge][iconRight]',
host: {
tuiIcons: '',
'[class._icon-left]': 'iconLeft',
'[class._icon-right]': 'iconRight',
'[style.--t-mask-left]': '"url(" + resolver(iconLeft) + ")"',
'[style.--t-mask-right]': '"url(" + resolver(iconRight) + ")"',
},
})
export class TuiIconsDirective {
@Input()
iconLeft = '';

@Input()
iconRight = '';

constructor(
@Inject(TUI_ICON_RESOLVER) readonly resolver: TuiStringHandler<string>,
@Inject(TuiDirectiveStylesService) directiveStyles: TuiDirectiveStylesService,
) {
directiveStyles.addComponent(TuiIconsComponent);
}
}
10 changes: 10 additions & 0 deletions projects/experimental/directives/icons/icons.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import {NgModule} from '@angular/core';

import {TuiIconsComponent} from './icons.component';
import {TuiIconsDirective} from './icons.directive';

@NgModule({
declarations: [TuiIconsComponent, TuiIconsDirective],
exports: [TuiIconsDirective],
})
export class TuiIconsModule {}
24 changes: 24 additions & 0 deletions projects/experimental/directives/icons/icons.styles.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
@import '@taiga-ui/core/styles/taiga-ui-local';

[tuiIcons] {
&._icon-left:before {
content: '';
}

&._icon-right:after {
content: '';
}

&:before,
&:after {
width: 1em;
height: 1em;
font-size: 1.5rem;
background: currentColor;
mask: var(--t-mask-left) no-repeat center/contain;
}

&:after {
mask: var(--t-mask-right) no-repeat center/contain;
}
}
3 changes: 3 additions & 0 deletions projects/experimental/directives/icons/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './icons.component';
export * from './icons.directive';
export * from './icons.module';
5 changes: 5 additions & 0 deletions projects/experimental/directives/icons/ng-package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"lib": {
"entryFile": "index.ts"
}
}
1 change: 1 addition & 0 deletions projects/experimental/directives/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export * from '@taiga-ui/experimental/directives/button-vertical';
export * from '@taiga-ui/experimental/directives/card';
export * from '@taiga-ui/experimental/directives/cell';
export * from '@taiga-ui/experimental/directives/fade';
export * from '@taiga-ui/experimental/directives/icons';
export * from '@taiga-ui/experimental/directives/progress-segmented';
export * from '@taiga-ui/experimental/directives/sensitive';
export * from '@taiga-ui/experimental/directives/surface';
Expand Down
Loading