Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Icons add new directive #6053

Merged
merged 5 commits into from
Nov 22, 2023
Merged

feat(experimental): Icons add new directive #6053

merged 5 commits into from
Nov 22, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Nov 22, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Visit the preview URL for this PR (updated for commit 0249728):

https://taiga-ui--pr6053-icons-26xreqfa.web.app

(expires Thu, 23 Nov 2023 12:30:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Nov 22, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
40.63KB (-15B -0.04%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
343.93KB +10%
demo/browser/vendor.(hash).js
198.14KB +10%
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change -15B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.26MB (+259B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c27ef2d) 71.94% compared to head (0249728) 71.94%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6053   +/-   ##
=======================================
  Coverage   71.94%   71.94%           
=======================================
  Files        1462     1462           
  Lines       15970    15970           
  Branches     2266     2266           
=======================================
  Hits        11489    11489           
  Misses       4110     4110           
  Partials      371      371           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.62% <ø> (ø)
addon-mobile 60.61% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.64% <ø> (ø)
core 77.99% <ø> (ø)
kit 70.18% <ø> (ø)
summary 71.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 6883895 into main Nov 22, 2023
34 checks passed
@splincode splincode deleted the icons branch November 22, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants