-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): introduce new version of InputNumber
#10099
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit e6dc7d2): https://taiga-previews-demo--pr10099-new-input-number-demo-bikgkcha.web.app (expires Sun, 29 Dec 2024 12:52:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10099 +/- ##
=======================================
Coverage 65.98% 65.98%
=======================================
Files 1227 1227
Lines 15997 15997
Branches 2327 2375 +48
=======================================
Hits 10555 10555
+ Misses 5161 5099 -62
- Partials 281 343 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +243B +0.04% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test results 2 failed Details Open report ↗︎ Failed testschromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-number Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
This PR is the last step of huge refactor:
InputNumber
#10031InputNumber
has[step]
feature #10073New version of
InputNumber
is the stable API now!