refactor(kit): new version of `InputNumber` #10031

nsbarsukov · 2024-12-19T12:42:15Z

No description provided.

lumberjack-bot · 2024-12-19T12:43:11Z

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

projects/demo/src/modules/app/app.routes.ts

github-actions · 2024-12-19T12:43:52Z

Visit the preview URL for this PR (updated for commit 47f19bd):

https://taiga-previews-demo--pr10031-input-number-refactor-dem-cbv8nqdq.web.app

_{(expires Wed, 25 Dec 2024 15:49:15 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37}

codecov · 2024-12-19T12:47:22Z

Codecov Report

Attention: Patch coverage is 28.08989% with 64 lines in your changes missing coverage. Please review.

Project coverage is 65.56%. Comparing base (c12ceaa) to head (47f19bd).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
.../components/input-number/input-number.component.ts	21.51%	57 Missing and 5 partials ⚠️
projects/cdk/classes/value-transformer.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           main   #10031       +/-   ##
=========================================
+ Coverage      0   65.56%   +65.56%     
=========================================
  Files         0     1222     +1222     
  Lines         0    15907    +15907     
  Branches      0     2327     +2327     
=========================================
+ Hits          0    10429    +10429     
- Misses        0     5216     +5216     
- Partials      0      262      +262

Flag	Coverage Δ
summary	`65.56% <28.08%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bundlemon · 2024-12-19T12:51:44Z

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	306.41KB (+1.23KB +0.4%)	+10%
✅	demo/browser/runtime.(hash).js	44.09KB (+39B +0.09%)	+10%

Unchanged files (3)

Status	Path	Size	Limits
✅	demo/browser/vendor.(hash).js	260.25KB	+10%
✅	demo/browser/styles.(hash).css	20.2KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +1.26KB +0.2%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.43MB (+44.23KB +0.58%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

projects/demo-playwright/tests/legacy/input-number/input-number.pw.spec.ts

projects/demo/src/modules/components/input-number-legacy/examples/1/index.html

projects/kit/components/input-number/input-number.component.ts

github-actions · 2024-12-19T14:13:54Z

Playwright test results

167 failed
1828 passed
1 flaky
82 skipped

Details

Open report ↗︎
2078 tests across 70 suites
24 minutes, 30 seconds
47f19bd

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /legacy/input-number
webkit › tests/deep/deep-select.pw.spec.ts › Deep / Select › /legacy/input-number
chromium › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /legacy/input-number
webkit › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /legacy/input-number
chromium › tests/demo/demo.pw.spec.ts › Demo › /legacy/input-number
webkit › tests/demo/demo.pw.spec.ts › Demo › /legacy/input-number
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › rejects minus sign
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › validates positive value (less than [min]) only on blur
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › allows to enter multi-length positive value (which is less than [min])
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › rejects minus sign
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › validates positive value (less than [min]) only on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › allows to enter multi-length positive value (which is less than [min])
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › immediately validates negative value
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › do not touch any positive value
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › immediately validates negative value
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › do not touch any positive value
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is negative number › validates negative value only on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is negative number › validates negative value only on blur
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › immediately validates positive value
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › do not touch any negative value
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › immediately validates positive value
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › do not touch any negative value
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › forbids to erase prefix › using Backspace many times
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › forbids to erase prefix › select all + Backspace
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › forbids to erase prefix › select all + Delete
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › forbids to erase prefix › using Backspace many times
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › forbids to erase prefix › select all + Backspace
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › forbids to erase prefix › select all + Delete
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › does not show suffixes for unfocused empty textfield
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › shows suffixes for empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › does not shows prefix for READONLY empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › does not show suffixes for unfocused empty textfield
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › shows suffixes for empty textfield on focus
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › does not shows prefix for READONLY empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › forbids to erase prefix › using Backspace many times
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › forbids to erase prefix › select all + Backspace
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › forbids to erase prefix › select all + Delete
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › forbids to erase prefix › using Backspace many times
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › forbids to erase prefix › select all + Backspace
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › forbids to erase prefix › select all + Delete
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › does not show suffixes for unfocused empty textfield
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › shows suffixes for empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › does not shows prefix for READONLY empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › does not show suffixes for unfocused empty textfield
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › shows suffixes for empty textfield on focus
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › does not shows prefix for READONLY empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › forbids to erase prefix › using Backspace many times
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › forbids to erase prefix › select all + Backspace
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › forbids to erase prefix › select all + Delete
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › forbids to erase prefix › using Backspace many times
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › forbids to erase prefix › select all + Backspace
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › forbids to erase prefix › select all + Delete
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › does not show suffixes for unfocused empty textfield
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › shows suffixes for empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › does not shows prefix for READONLY empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › does not show suffixes for unfocused empty textfield
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › shows suffixes for empty textfield on focus
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › does not shows prefix for READONLY empty textfield on focus
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [precision] prop › [precision]=0
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [precision] prop › [precision]=2
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [precision] prop › [precision]=0
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [precision] prop › [precision]=2
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [thousandSeparator] prop › _
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [thousandSeparator] prop › .
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [thousandSeparator] prop › _
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [thousandSeparator] prop › .
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalSeparator] prop › .
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalSeparator] prop › .
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=not-zero | 42 => Blur => 42
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=not-zero | 42.1 => Blur => 42.1
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=not-zero | 42.00 => Blur => 42
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=pad | 42.1 => Blur => 42.10
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=always | Enter 42 => 42.00
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=not-zero | 42 => Blur => 42
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=not-zero | 42.1 => Blur => 42.1
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=not-zero | 42.00 => Blur => 42
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=pad | 42.1 => Blur => 42.10
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [decimalMode] prop › decimalMode=always | Enter 42 => 42.00
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.00| => Backspace => 105.0|0
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.0|0 => Backspace => 105.|00
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.|00 => Backspace => 105|.00
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.|00 => Delete => 105.0|0
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.00| => Backspace => 105.0|0
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.0|0 => Backspace => 105.|00
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.|00 => Backspace => 105|.00
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105.|00 => Delete => 105.0|0
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1| 000 => Delete => 1 |000
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1 |000 => Backspace => 1| 000
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1| 000 => Delete => 1 |000
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1 |000 => Backspace => 1| 000
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Empty textfield | s
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Textfield has value | s
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Empty textfield | m
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Textfield has value | m
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Empty textfield | l
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Textfield has value | l
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Empty textfield | s
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Textfield has value | s
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Empty textfield | m
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Textfield has value | m
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Empty textfield | l
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [tuiTextfieldSize] prop › Textfield has value | l
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › does not mutate already valid too large number on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › does not mutate already valid too large number on blur
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › overflow › sandboxWidth=75
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › overflow › sandboxWidth=140
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › overflow › sandboxWidth=158
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › overflow › sandboxWidth=75
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › overflow › sandboxWidth=140
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › overflow › sandboxWidth=158
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,00| => Backspace => 105,0|0
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,0|0 => Backspace => 105,|00
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,|00 => Backspace => 105|,00
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,|00 => Delete => 105,0|0
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,00| => Backspace => 105,0|0
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,0|0 => Backspace => 105,|00
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,|00 => Backspace => 105|,00
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase padded decimal zeroes (decimalMode="always"), mask triggers caret navigation › 105,|00 => Delete => 105,0|0
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1| 000 => Delete => 1 |000
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1 |000 => Backspace => 1| 000
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1| 000 => Delete => 1 |000
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Caret navigation › if user tries to erase thousand separator, mask triggers caret navigation › 1 |000 => Backspace => 1| 000
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › rejects minus sign
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › validates positive value only on blur
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › rejects minus sign
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is positive number › validates positive value only on blur
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › immediately validates negative value
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › don't touch any positive value
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › immediately validates negative value
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › [min] property is negative number › don't touch any positive value
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › positive [min] property and positive value (which is less than [min])
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [min] prop › positive [min] property and positive value (which is less than [min])
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is negative number › validates negative value only on blur
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is negative number › validates negative value only on blur
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › immediately validates positive value
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › don't touch any negative value
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › immediately validates positive value
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › [max] prop › [max] property is positive number › don't touch any negative value
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42 (decimalMode=not-zero) => 42
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,1 (decimalMode=not-zero) => 42,1
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,1 (decimalMode=pad) => 42,10
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,00 (decimalMode=not-zero) => 42
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,1 (precision=0) => 42
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42 (decimalMode=always) => 42.00
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › text field does not contain any digit (only prefix + postfix) => clear text field's value on blur
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42 (decimalMode=not-zero) => 42
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,1 (decimalMode=not-zero) => 42,1
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,1 (decimalMode=pad) => 42,10
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,00 (decimalMode=not-zero) => 42
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42,1 (precision=0) => 42
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › Value 42 (decimalMode=always) => 42.00
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › value formatting on blur › text field does not contain any digit (only prefix + postfix) => clear text field's value on blur
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Infinite precision
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › does not mutate already valid too large number on blur
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › prefix + value + postfix
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › align=left
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › align=right
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Infinite precision
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › does not mutate already valid too large number on blur
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › prefix + value + postfix
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › align=left
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › align=right
chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › Examples › cursor position
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › Examples › cursor position

Flaky tests

chromium › tests/core/hint/hint.pw.spec.ts › TuiHint › true mode hint with delay

Skipped tests

webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with saved cards
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › expired field should be clickable after reset of prefilled value
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-code"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll after click on link with anchor
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [light mode]
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [dark mode]
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Submenu
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Form control
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Complex
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 320x480
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 720x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1024x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1620x1024
webkit › tests/core/surface/surface.pw.spec.ts › Surface › Layers
webkit › tests/kit/carousel/carousel.pw.spec.ts › Carousel › should show next item after drag
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the beginning of the track changes only nearest (left) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the end of the track changes only nearest (right) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click between two thumbs triggers only nearest thumb
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on right slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on left slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Left decreases by one step (after setting right thumb active via click)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set left thumb more than right thumb (by Arrow Right)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set right thumb less than left thumb (by ArrowLeft)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowUp increases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowDown decreases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the LEFT slider MORE THAN position of the RIGHT slider (by ArrowUp)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the RIGHT slider LESS THAN position of the LEFT slider (by ArrowDown)
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › decrease value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 2 steps
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › no extra margin after the last tab
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show settings in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show hint in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › A12y
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is visible when the input is focused
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for s size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for m size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for l size

projects/demo/src/components/control/index.ts

projects/kit/components/input-number/input-number.options.ts

projects/kit/components/input-number/input-number.component.ts

nsbarsukov self-assigned this Dec 19, 2024

nsbarsukov commented Dec 19, 2024

View reviewed changes

projects/demo/src/modules/app/app.routes.ts Show resolved Hide resolved

nsbarsukov changed the title ~~[WIP] feat(kit): new refactored version of InputNumber~~ [WIP] refactor(kit): new version of InputNumber Dec 19, 2024

nsbarsukov commented Dec 19, 2024

View reviewed changes

projects/demo-playwright/tests/legacy/input-number/input-number.pw.spec.ts Show resolved Hide resolved

nsbarsukov commented Dec 19, 2024

View reviewed changes

projects/demo/src/modules/components/input-number-legacy/examples/1/index.html Outdated Show resolved Hide resolved

nsbarsukov commented Dec 19, 2024

View reviewed changes

projects/kit/components/input-number/input-number.component.ts Show resolved Hide resolved

nsbarsukov force-pushed the input-number-refactor branch from ae8dc83 to abbf88f Compare December 19, 2024 14:14

nsbarsukov changed the title ~~[WIP] refactor(kit): new version of InputNumber~~ refactor(kit): new version of InputNumber Dec 19, 2024

nsbarsukov marked this pull request as ready for review December 19, 2024 14:21

nsbarsukov requested a review from a team as a code owner December 19, 2024 14:21

nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 19, 2024 14:21

nsbarsukov mentioned this pull request Dec 19, 2024

chore(demo): use modern API page approach for documentation about [tuiNumberFormat] #10034

Merged

nsbarsukov added 2 commits December 20, 2024 14:13

feat(kit): new refactored version of InputNumber

00512e5

chore: fix merge conflict

196b579

nsbarsukov force-pushed the input-number-refactor branch from abbf88f to 196b579 Compare December 20, 2024 11:26

splincode approved these changes Dec 23, 2024

View reviewed changes

waterplea reviewed Dec 24, 2024

View reviewed changes

nsbarsukov added 2 commits December 24, 2024 17:36

chore: fix some code review comments

21703a5

chore: new utility tuiValueTransformerFrom

f6354be

waterplea approved these changes Dec 24, 2024

View reviewed changes

github-actions bot added the ready to merge label Dec 24, 2024

chore: revert hiding of new demo route

47f19bd

splincode merged commit a1b748c into main Dec 24, 2024
34 checks passed

splincode deleted the input-number-refactor branch December 24, 2024 18:56

This was referenced Dec 27, 2024

refactor(kit): new version of InputNumber has [step] feature #10073

Merged

feat(kit): introduce new version of InputNumber #10099

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(kit): new version of `InputNumber` #10031

refactor(kit): new version of `InputNumber` #10031

nsbarsukov commented Dec 19, 2024

lumberjack-bot bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

bundlemon bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

refactor(kit): new version of InputNumber #10031

refactor(kit): new version of InputNumber #10031

Conversation

nsbarsukov commented Dec 19, 2024

lumberjack-bot bot commented Dec 19, 2024 • edited Loading

Pull request was closed ✔️

github-actions bot commented Dec 19, 2024 • edited Loading

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

bundlemon bot commented Dec 19, 2024 • edited Loading

BundleMon

github-actions bot commented Dec 19, 2024 • edited Loading

Playwright test results

Details

refactor(kit): new version of `InputNumber` #10031

refactor(kit): new version of `InputNumber` #10031

lumberjack-bot bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

bundlemon bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading