🐞 - `Cannot set property ɵprov of function AbstractTuiDialogService(idService)` #1257

robingenz · 2022-01-25T21:14:51Z

Which @taiga-ui/* package(s) are the source of the bug?

core

Please provide a link to a minimal reproduction of the bug

https://github.com/robingenz/taiga-ui-issue-1257

Description

Hi, first of all thanks for this great library.
I have the following issue:
When I want to test a component or service that injects the TuiNotificationsService, I get the following error:

 FAIL  src/app/home/home.component.spec.ts
  ● Test suite failed to run

    TypeError: Cannot set property ɵprov of function AbstractTuiDialogService(idService) {
                var _this = _super.call(this, function (observer) { ...<omitted>... } which has only a getter

      1 | import { ComponentFixture, TestBed } from '@angular/core/testing';
    > 2 | import { TuiNotificationsService } from '@taiga-ui/core';
        | ^
      3 | import { createSpyObj } from 'src/tests/helpers';
      4 |
      5 | import { HomeComponent } from './home.component';

      at node_modules/@taiga-ui/core/bundles/taiga-ui-core-components-dialog.umd.js:402:32
      at node_modules/@taiga-ui/core/bundles/ng:/@taiga-ui/core/components/dialog/dialog.service.ts:24:2
      at node_modules/@taiga-ui/core/bundles/taiga-ui-core-components-dialog.umd.js:2:68
      at Object.<anonymous> (node_modules/@taiga-ui/core/bundles/taiga-ui-core-components-dialog.umd.js:5:2)
      at node_modules/@taiga-ui/core/bundles/taiga-ui-core-components.umd.js:2:222
      at Object.<anonymous> (node_modules/@taiga-ui/core/bundles/taiga-ui-core-components.umd.js:5:2)
      at node_modules/@taiga-ui/core/bundles/taiga-ui-core.umd.js:2:156
      at Object.<anonymous> (node_modules/@taiga-ui/core/bundles/taiga-ui-core.umd.js:5:2)
      at Object.<anonymous> (src/app/home/home.component.spec.ts:2:1)
      at TestScheduler.scheduleTests (node_modules/@jest/core/build/TestScheduler.js:333:13)
      at runJest (node_modules/@jest/core/build/runJest.js:404:19)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.672 s
Ran all test suites related to changed files.

Watch Usage: Press w to show more.

For testing, I use Jest.

Is there anything in particular that needs to be imported for the tests or have I missed anything else?

Angular version

13.1.0

Taiga UI version

2.31.0

Which browsers have you used?

Chrome
Firefox
Safari
Edge

Which operating systems have you used?

The text was updated successfully, but these errors were encountered:

waterplea · 2022-01-26T07:41:40Z

You don't need to import anything, it should work. That is very strange, notifications are unrelated to dialogs. Can you make a little repository with reproduction?

splincode · 2022-01-26T08:00:36Z

Repo for reproduce - https://github.com/robingenz/taiga-ui-issue-1257

robingenz · 2022-01-26T08:02:25Z

Thanks @splincode, was just about to write it. 😄 @waterplea Thank you for your fast response. Please let me know if you need more information.

waterplea · 2022-01-26T08:23:34Z

Ops, sorry, missed the link somehow )

syrok0010 · 2022-01-29T11:58:58Z

Also have this error. Thought that it was a problem with ng-mocks. But now believe it's not.
help-me-mom/ng-mocks#1711

robingenz · 2022-01-29T14:38:25Z

My biggest problem at the moment is that I can't use TuiNotificationsService at all, otherwise even my previous tests won't run anymore, since the TypeError is thrown immediately as soon as any other test has a reference to TuiNotificationsService.
First I thought I simply forgot to import a module, but according to #1257 (comment) it should work without import.

waterplea · 2022-01-31T13:42:50Z

Could it be something like this where compiler tries to compile service multiple times for some reason?
angular/angular#35993
Maybe there is some sort of optimization for tests in place that fails 🤔 I also found this which has no solution but is very similar in terms of dealing with decorated abstract class:
https://stackoverflow.com/questions/60633963/angular-9-production-error-cannot-set-property-%C9%B5fac-of-abstract-class-myfilte
This article seems to suggest a solution, but I haven't tried it yet:
https://qiita.com/yuma-ito-bd/items/cd32cb57e13f56b59f18
Running jest with no cache: $ jest hero.service --no-cache (could be relevant considering the first link I've mentioned) and adding "emitDecoratorMetadata": true to tsconfig.spec.ts.

syrok0010 · 2022-01-31T14:16:12Z

Unfortunately, neither jest --no-cache nor editing the tsconfig fixes the issue for me

robingenz · 2022-01-31T15:09:08Z

@waterplea Thank you for your time.

Could it be something like this where compiler tries to compile service multiple times for some reason? angular/angular#35993

I don't think so. The production build works fine and enabling/disabling optimizations does not bring any change.

I have tried both: Added "emitDecoratorMetadata": true and run Jest with --no-cache.
Unfortunately, the error persists.

satanTime · 2022-01-31T21:40:25Z

Looks like this version of taiga:

    "@taiga-ui/addon-mobile": "^2.31.0",
    "@taiga-ui/cdk": "^2.31.0",
    "@taiga-ui/core": "^2.31.0",
    "@taiga-ui/icons": "^2.31.0",
    "@taiga-ui/kit": "^2.31.0",

isn't compatible with jest on angular 13 well (perhaps wrong ivy build / config).

I've fixed your issue by running npx ngcc before running tests.

robingenz · 2022-01-31T21:49:19Z

I've fixed your issue by running npx ngcc before running tests.

I can confirm this.

@satanTime Thank you very much for your help!

waterplea · 2022-02-01T04:37:55Z

All current versions of Taiga require ngcc, it's weird that tests don't do this automatically 🤔

satanTime · 2022-02-01T07:01:14Z

as a guess, maybe the problem is in @angular-builders/jest:run and it doesn't trigger ngcc before its execution.

a way to check:
on a fresh clone of https://github.com/robingenz/taiga-ui-issue-1257 where ngcc hasn't been executed yet,
to try to run tests with standard @angular-devkit/build-angular:karma instead of jest.

if it triggers ngcc, then a fix should be done in @angular-builders/jest:run.
I'll try to check it next days.

waterplea · 2022-02-01T08:46:07Z

Giving it a P3 since it's probably not an issue with Taiga UI and I don't think there's much we can do. Adding some hacks in Taiga UI to run ngcc on postinstall seems a bit extreme to me, besides we want to migrate to Angular 12 in the next major release that we are working on anyway.

satanTime · 2022-02-01T09:52:07Z

Agree. Sounds like a talk for a runner and not a lib

splincode · 2022-02-01T10:23:36Z

@robingenz Hello, try add "postinstall": "ngcc --async" here https://github.com/robingenz/taiga-ui-issue-1257/blob/main/package.json#L4

robingenz · 2022-02-01T10:29:01Z

Thank you all for your help.

Hello, try add "postinstall": "ngcc --async" here robingenz/taiga-ui-issue-1257@main/package.json#L4

I have already added this exact line to my actual project and it works very well. So this is a good workaournd.

the-ult · 2022-06-09T09:36:28Z

Same issue still occurs with Angular 13/14

Even when using the postinstall: "ngcc ...." script (which is default when using Nx

spicy-tomato · 2022-08-15T00:50:36Z

Same issue still occurs with Angular 13/14

Even when using the postinstall: "ngcc ...." script (which is default when using Nx

Same issue here :/

zy2ba · 2023-01-12T07:19:45Z

Meets same issue after update to Angular 13 & nx 13. For me resolved by adding
globalSetup: 'jest-preset-angular/global-setup',
to jest config

robingenz added the bug label Jan 25, 2022

splincode added the state: need triage label Jan 29, 2022

satanTime mentioned this issue Jan 29, 2022

Mock fails help-me-mom/ng-mocks#1711

Closed

waterplea added P3 This issue has low priority and removed state: need triage labels Feb 1, 2022

splincode added the wontfix label Feb 1, 2022

splincode closed this as completed Feb 1, 2022

the-ult mentioned this issue Jun 9, 2022

🚀 - Update taige-ui to Angular 12 / Ivy compatible to reduce ngcc reliance #980

Closed

waterplea closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023

waterplea assigned splincode Aug 2, 2023

splincode added this to Taiga-family Sep 26, 2023

github-project-automation bot moved this to 💡 Backlog in Taiga-family Sep 26, 2023

splincode moved this from 💡 Backlog to ✅ Done in Taiga-family Sep 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐞 - `Cannot set property ɵprov of function AbstractTuiDialogService(idService)` #1257

🐞 - `Cannot set property ɵprov of function AbstractTuiDialogService(idService)` #1257

robingenz commented Jan 25, 2022

waterplea commented Jan 26, 2022

splincode commented Jan 26, 2022

robingenz commented Jan 26, 2022

waterplea commented Jan 26, 2022

syrok0010 commented Jan 29, 2022 •

edited

Loading

robingenz commented Jan 29, 2022

waterplea commented Jan 31, 2022

syrok0010 commented Jan 31, 2022 •

edited

Loading

robingenz commented Jan 31, 2022

satanTime commented Jan 31, 2022 •

edited

Loading

robingenz commented Jan 31, 2022

waterplea commented Feb 1, 2022

satanTime commented Feb 1, 2022 •

edited

Loading

waterplea commented Feb 1, 2022

satanTime commented Feb 1, 2022

splincode commented Feb 1, 2022

robingenz commented Feb 1, 2022

the-ult commented Jun 9, 2022 •

edited

Loading

spicy-tomato commented Aug 15, 2022

zy2ba commented Jan 12, 2023

🐞 - Cannot set property ɵprov of function AbstractTuiDialogService(idService) #1257

🐞 - Cannot set property ɵprov of function AbstractTuiDialogService(idService) #1257

Comments

robingenz commented Jan 25, 2022

Which @taiga-ui/* package(s) are the source of the bug?

Please provide a link to a minimal reproduction of the bug

Description

Angular version

Taiga UI version

Which browsers have you used?

Which operating systems have you used?

waterplea commented Jan 26, 2022

splincode commented Jan 26, 2022

robingenz commented Jan 26, 2022

waterplea commented Jan 26, 2022

syrok0010 commented Jan 29, 2022 • edited Loading

robingenz commented Jan 29, 2022

waterplea commented Jan 31, 2022

syrok0010 commented Jan 31, 2022 • edited Loading

robingenz commented Jan 31, 2022

satanTime commented Jan 31, 2022 • edited Loading

robingenz commented Jan 31, 2022

waterplea commented Feb 1, 2022

satanTime commented Feb 1, 2022 • edited Loading

waterplea commented Feb 1, 2022

satanTime commented Feb 1, 2022

splincode commented Feb 1, 2022

robingenz commented Feb 1, 2022

the-ult commented Jun 9, 2022 • edited Loading

spicy-tomato commented Aug 15, 2022

zy2ba commented Jan 12, 2023

🐞 - `Cannot set property ɵprov of function AbstractTuiDialogService(idService)` #1257

🐞 - `Cannot set property ɵprov of function AbstractTuiDialogService(idService)` #1257

syrok0010 commented Jan 29, 2022 •

edited

Loading

syrok0010 commented Jan 31, 2022 •

edited

Loading

satanTime commented Jan 31, 2022 •

edited

Loading

satanTime commented Feb 1, 2022 •

edited

Loading

the-ult commented Jun 9, 2022 •

edited

Loading