Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Update taige-ui to Angular 12 / Ivy compatible to reduce ngcc reliance #980

Closed
the-ult opened this issue Nov 8, 2021 · 14 comments · Fixed by #2110
Closed

🚀 - Update taige-ui to Angular 12 / Ivy compatible to reduce ngcc reliance #980

the-ult opened this issue Nov 8, 2021 · 14 comments · Fixed by #2110
Assignees
Labels
P1 This issue has high priority

Comments

@the-ult
Copy link

the-ult commented Nov 8, 2021

Which @taiga-ui/* package(s) are relevant/releated to the feature request?

ALL

Description

Update taiga to Angular 13, so we don't have to use/wait for ngcc to re-compile to Ivy.

Related issue(s):

@hheexx
Copy link
Contributor

hheexx commented Nov 11, 2021

Angular 13 started giving warnings about taiga-ui beeing in legacy format.

@waterplea
Copy link
Collaborator

This would be a breaking change, we cannot bump until all internal projects are bumped and even besides internal projects, it would make Taiga UI incompatible with anything below latest Angular. That's not something we want to do right now. We will keep it in the candidates for the next major version.

@the-ult
Copy link
Author

the-ult commented Nov 12, 2021

Any change it is possible to create a new Major (breaking change) version, before all internal projects are upgraded?
(since upgrading to the newest taiga-ui is optional)
Or does this create too many problems with existing issues (feat and bugs) and keeping it in sync with the internal projects?

BTW: Love the work you are doing with taiga-ui and the great blog post/articles etc 👍

@waterplea
Copy link
Collaborator

Yes, unfortunately, it's too much double work keeping 2 major versions around. We know that first hand since we did that for 0.x to 1.x and have 1.x to 2.x now, everything below 2.x being internal versions before open source release. We are working on updating internal projects, it's not something we passively wait, so I'm gonna have to ask for patience :)

@hheexx
Copy link
Contributor

hheexx commented Nov 12, 2021

@waterplea As far as I know Ivy distribution can be understood by all angular applications that use Ivy (9+). It's not just for latest Angular version.

Also there should not be a lot of work to have 2 major versions around. Most of libraries do it to support different angular versions. The only difference between versions should be in tsconfig:
"angularCompilerOptions": {
"enableIvy": true,
"compilationMode": "partial"
}

that should not be big burden to maintain for a limited time.

@brianpooe
Copy link

I agree with @hheexx our project is up to date and only taiga ui is slowing the build process with ngcc. Would be nice to have v13 branched out at least.

@hakimio
Copy link
Contributor

hakimio commented Feb 1, 2022

@hheexx That's not true. Ivy partial compilation works only with Angular 12+. Read the docs.

@waterplea waterplea added P1 This issue has high priority and removed state: need triage labels Feb 1, 2022
@the-ult
Copy link
Author

the-ult commented Jun 8, 2022

Any news on the progress? Since Angular 14 is already released?

@nsbarsukov
Copy link
Member

nsbarsukov commented Jul 12, 2022

In 3.x.x version of our Taiga UI we are going to update our libs to the 12th Angular.

  • Angular 10
  • Angular 11
  • Angular 12

Also, with 3.x.x we drop legacy View Engine-support.

@the-ult
Copy link
Author

the-ult commented Jul 12, 2022

What is the reason the update is until version 12 instead of the current version => 14?
The upgrade process from 12 to 14 is pretty smooth.

@nsbarsukov
Copy link
Member

@the-ult Hi!
Of course, we also want to use the latest version of Angular.
But there are some restrictions.

Taiga UI is used inside a huge number of our internal projects.
Some of them can still use old versions of Angular.

We believe that Angular 12 can be better for compatibility with old versions of Angular.
Moreover, we've decided that Angular 12 is enough for our purposes for now.
That is why upcoming major release v3.x.x of Taiga UI will introduce only Angular 12.

Of course, in future releases we will update our Angular to more modern version (maybe in v4.x.x or later) !

@hakimio
Copy link
Contributor

hakimio commented Jul 12, 2022

Are you going to at least drop "View Engine" compatibility?

@nsbarsukov
Copy link
Member

@hakimio yes

@nsbarsukov nsbarsukov linked a pull request Jul 13, 2022 that will close this issue
@nsbarsukov nsbarsukov changed the title 🚀 - Update taige-ui to Angular 13 / Ivy compatible to reduce ngcc reliance 🚀 - Update taige-ui to Angular 12 / Ivy compatible to reduce ngcc reliance Jul 14, 2022
@waterplea
Copy link
Collaborator

I'll resolve this issue as we have released the first RC of 3.0 which got this covered. I'm hoping to have one more RC at most and then 3.0 is out.

@splincode splincode self-assigned this Sep 25, 2023
@splincode splincode moved this to ✅ Done in Taiga-family Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 This issue has high priority
Development

Successfully merging a pull request may close this issue.

7 participants