-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update templates dependencies #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I've tested it locally and it looks like every dependency is updated, thanks a lot.
As I stated in a comment bellow, we need to remove package-lock.json
as yarn
is used here as a package manager.
Other tip: I saw that you've changed the PR name and indeed that was good decision, but the title isn't quite good enough yet. Always remember that the best commit/pr title states what changed, so that reader can easily understand what was changed. Much better title would be something like: "Update templates dependencies"
When it comes to the deprecation message: I'll try to make an update after this PR is merged.
Def need to check this |
Yeah, it was failing because In case you don't know how to do this:
|
I already merged master into main without rebasing. Should i revert that merge and then rebase instead? |
No you don't have to, it should be fine with merge also. With merge commit you can just |
thanks for letting me know about rebase. Will look into that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is working fine, great job! 🎉
Thanks a lot for your contribution!
thanks for letting me know about rebase. Will look into that
To be honest it's just a preference thing, you can look into a rebase vs merge
debate, but it the end it comes down to the project and people you are working on.
Also, your changes won't be available immediately because there is still work around getting rid off the warning to do, so I'll let you know here when the update will be ready. Unless you want to do another contribution 😅 |
I could try see if i can fix the warning as well. It would be a fun challange :) I'll look into it later today. Should open another issue for this? |
I think that you can just open a PR when you have changes, but if you want some guidance how to work on those warnings, then you can open an issue for clarity. I've did some research yesterday so I have a little bit of knowledge about how to handle that, so I'll be happy to share it with you. |
yes I think some guidance would be helpful :) Thanks! |
No description provided.