Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates dependencies #94

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

pontusva
Copy link
Contributor

No description provided.

@pontusva pontusva marked this pull request as ready for review November 21, 2023 16:59
@pontusva pontusva changed the title All tests passed All tests passed with updated template dependencies Nov 21, 2023
Copy link
Owner

@szymmis szymmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've tested it locally and it looks like every dependency is updated, thanks a lot.

As I stated in a comment bellow, we need to remove package-lock.json as yarn is used here as a package manager.

Other tip: I saw that you've changed the PR name and indeed that was good decision, but the title isn't quite good enough yet. Always remember that the best commit/pr title states what changed, so that reader can easily understand what was changed. Much better title would be something like: "Update templates dependencies"

When it comes to the deprecation message: I'll try to make an update after this PR is merged.

package-lock.json Outdated Show resolved Hide resolved
@szymmis szymmis linked an issue Nov 21, 2023 that may be closed by this pull request
@pontusva pontusva changed the title All tests passed with updated template dependencies Update templates dependencies Nov 22, 2023
@pontusva
Copy link
Contributor Author

Def need to check this

@szymmis
Copy link
Owner

szymmis commented Nov 22, 2023

Yeah, it was failing because Vite 5 needs node 18 or 20, and we were using 16 in the CI. I've created and merged bump in #95, so you can now try to pull the changes and rebase. Could you do that for me?

In case you don't know how to do this:

  1. Checkout to master branch in your project
  2. git fetch
  3. git pull
  4. Checkout to the update-dependencies branch
  5. git rebase master
  6. git push --force-with-lease

@pontusva
Copy link
Contributor Author

Yeah, it was failing because Vite 5 needs node 18 or 20, and we were using 16 in the CI. I've created and merged bump in #95, so you can now try to pull the changes and rebase. Could you do that for me?

In case you don't know how to do this:

1. Checkout to `master` branch in your project

2. `git fetch`

3. `git pull`

4. Checkout to the `update-dependencies` branch

5. `git rebase master`

6. `git push --force-with-lease`

I already merged master into main without rebasing. Should i revert that merge and then rebase instead?

@szymmis
Copy link
Owner

szymmis commented Nov 22, 2023

No you don't have to, it should be fine with merge also. With merge commit you can just git push then I guess.

@pontusva
Copy link
Contributor Author

thanks for letting me know about rebase. Will look into that

Copy link
Owner

@szymmis szymmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is working fine, great job! 🎉
Thanks a lot for your contribution!

thanks for letting me know about rebase. Will look into that

To be honest it's just a preference thing, you can look into a rebase vs merge debate, but it the end it comes down to the project and people you are working on.

@szymmis szymmis merged commit 8d6d910 into szymmis:master Nov 22, 2023
2 checks passed
@szymmis
Copy link
Owner

szymmis commented Nov 22, 2023

Also, your changes won't be available immediately because there is still work around getting rid off the warning to do, so I'll let you know here when the update will be ready.

Unless you want to do another contribution 😅

@pontusva
Copy link
Contributor Author

I could try see if i can fix the warning as well. It would be a fun challange :) I'll look into it later today. Should open another issue for this?

@szymmis
Copy link
Owner

szymmis commented Nov 22, 2023

I think that you can just open a PR when you have changes, but if you want some guidance how to work on those warnings, then you can open an issue for clarity. I've did some research yesterday so I have a little bit of knowledge about how to handle that, so I'll be happy to share it with you.

@pontusva
Copy link
Contributor Author

yes I think some guidance would be helpful :) Thanks!

@pontusva pontusva deleted the update-dependencies branch November 22, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nodemon SemVer to ^3.0.0
2 participants