-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodemon SemVer to ^3.0.0 #93
Comments
Hi @pontusva, thanks for letting me know. I guess you are talking about |
No no, you got the repo right. The Maybe you want to make a contribution and update the dependencies? If you do, I'll be happy to answer any questions you'll have and provide guidance! If not then no problem and as I said, I'll try to find some free time to update them. |
Oh okay, thank you for letting me know :) Is there a specific workflow for contributing? |
Happy to hear that! There is no official guideline at the moment. That means all you have to do is to:
As soon as the PR shows up I'll try to check it out, and we can discuss details there. In terms of requirements: I'd like you to update every dependency you can in every template. And as I said earlier, when you are ready, just open the PR. |
Ok, I'll look into this :) and reply here if i have any further questions |
Hey @szymmis I'm a bit new to forking and contributing in general. But i've made a fork and updated all dependecies. All tests passed. But i noticed this: https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated And also i pushed to branch on the fork i made but it seems that it is connected to this repo? Maybe that¨s normal behaviour :) edit: did run |
Okay, that link looks interesting, definitely something I need to check out. Yeah, your fork is connected to this repository, that's how they work. It's different from just creating a new repository on your account and pasting all the files there. Forks are generally used as a way to implement some changes to public repositories that you don't have write access as this one. It is de facto a standard of contributing. |
yes, it's in the output when the tests run. Alright :) thanks for updating |
Tried it and everything seems to work with the updated nodemon version.
The text was updated successfully, but these errors were encountered: