Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodemon SemVer to ^3.0.0 #93

Closed
pontusva opened this issue Nov 19, 2023 · 9 comments · Fixed by #94
Closed

Update nodemon SemVer to ^3.0.0 #93

pontusva opened this issue Nov 19, 2023 · 9 comments · Fixed by #94

Comments

@pontusva
Copy link
Contributor

Tried it and everything seems to work with the updated nodemon version.

@szymmis
Copy link
Owner

szymmis commented Nov 20, 2023

Hi @pontusva, thanks for letting me know. I guess you are talking about create-vite-express templates, yeah, their dependencies are a little bit outdated so I'll try to update them.

@pontusva
Copy link
Contributor Author

@szymmis Hey!
Yes, that was what i was referring to. I think i got the repos mixed up?

Hi @pontusva, thanks for letting me know. I guess you are talking about create-vite-express templates, yeah, their dependencies are a little bit outdated so I'll try to update them.

@szymmis
Copy link
Owner

szymmis commented Nov 21, 2023

No no, you got the repo right. The create-vite-express is a subpackage of this repo.

Maybe you want to make a contribution and update the dependencies? If you do, I'll be happy to answer any questions you'll have and provide guidance! If not then no problem and as I said, I'll try to find some free time to update them.
Either way, thanks again for letting me know!

@pontusva
Copy link
Contributor Author

No no, you got the repo right. The create-vite-express is a subpackage of this repo.

Maybe you want to make a contribution and update the dependencies? If you do, I'll be happy to answer any questions you'll have and provide guidance! If not then no problem and as I said, I'll try to find some free time to update them. Either way, thanks again for letting me know!

Oh okay, thank you for letting me know :)
I'd really like to contribute and update the dependencies. I would be my first contribution and this seems like a good one to start with.

Is there a specific workflow for contributing?

@szymmis
Copy link
Owner

szymmis commented Nov 21, 2023

Happy to hear that!

There is no official guideline at the moment. That means all you have to do is to:

  1. fork the repository
  2. make changes on your fork
  3. create a PR onto this repository.

As soon as the PR shows up I'll try to check it out, and we can discuss details there.

In terms of requirements: I'd like you to update every dependency you can in every template.
You can run npm run test to check out if your changes work. I know that there are problems with tests on Windows. In that case you can simply create a local project and check it there manually. Whatever workflow suits you.

And as I said earlier, when you are ready, just open the PR.
Feel free to ask if anything is still unclear.

@pontusva
Copy link
Contributor Author

Ok, I'll look into this :) and reply here if i have any further questions

@pontusva
Copy link
Contributor Author

pontusva commented Nov 21, 2023

Hey @szymmis

I'm a bit new to forking and contributing in general. But i've made a fork and updated all dependecies. All tests passed. But i noticed this: https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated

And also i pushed to branch on the fork i made but it seems that it is connected to this repo? Maybe that¨s normal behaviour :)

edit: did run npm audit fix --force at the root of the repo.

@szymmis
Copy link
Owner

szymmis commented Nov 21, 2023

Okay, that link looks interesting, definitely something I need to check out.
Are you getting some kind of warnings or how did you stumbled upon this?

Yeah, your fork is connected to this repository, that's how they work. It's different from just creating a new repository on your account and pasting all the files there. Forks are generally used as a way to implement some changes to public repositories that you don't have write access as this one. It is de facto a standard of contributing.
You can open a PR now merging your branch onto this one.
That way I'll be able to check it out and test myself.

@pontusva
Copy link
Contributor Author

yes, it's in the output when the tests run.

Alright :) thanks for updating

@szymmis szymmis linked a pull request Nov 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants