✅ Enable Deprecation Helper in Tests

phpunit.xml

@@ -21,7 +21,7 @@
         <env name="APP_DEBUG" value="1"/>
         <env name="APP_SECRET" value="s$cretf0rt3st"/>
         <env name="SHELL_VERBOSITY" value="-1"/>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak"/>
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=0"/>
         <!-- define your env variables for the test env here -->
     </php>
     <testsuites>

src/Form/AliasDeleteType.php

@@ -12,7 +12,7 @@ class AliasDeleteType extends AbstractType
 {
     public const NAME = 'delete_alias';
 
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options) : void
     {
         $builder
             ->add('password', PasswordType::class, ['label' => 'form.delete-password'])
@@ -22,15 +22,15 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     /**
      * {@inheritdoc}
      */
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver) : void
     {
         $resolver->setDefaults(['data_class' => 'App\Form\Model\Delete']);
     }
 
     /**
      * @return string
      */
-    public function getBlockPrefix()
+    public function getBlockPrefix() : string
     {
         return self::NAME;
     }

src/Form/CustomAliasCreateType.php

@@ -12,7 +12,7 @@ class CustomAliasCreateType extends AbstractType
 {
     public const NAME = 'create_custom_alias';
 
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options) : void
     {
         $builder
             ->add('alias', TextType::class, ['label' => 'form.new-custom-alias'])
@@ -22,15 +22,15 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     /**
      * {@inheritdoc}
      */
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver) : void
     {
         $resolver->setDefaults(['data_class' => 'App\Form\Model\AliasCreate']);
     }
 
     /**
      * @return string
      */
-    public function getBlockPrefix()
+    public function getBlockPrefix() : string
     {
         return self::NAME;
     }

src/Form/OpenPgpDeleteType.php

@@ -12,7 +12,7 @@ class OpenPgpDeleteType extends AbstractType
 {
     public const NAME = 'delete_openpgp';
 
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options) : void
     {
         $builder
             ->add('password', PasswordType::class, ['label' => 'form.delete-password'])
@@ -22,15 +22,15 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     /**
      * {@inheritdoc}
      */
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver) : void
     {
         $resolver->setDefaults(['data_class' => 'App\Form\Model\Delete']);
     }
 
     /**
      * @return string
      */
-    public function getBlockPrefix()
+    public function getBlockPrefix() : string
     {
         return self::NAME;
     }

src/Form/RegistrationType.php

@@ -31,7 +31,7 @@ public function __construct(EntityManagerInterface $manager)
         $this->domain = $manager->getRepository(Domain::class)->getDefaultDomain()->getName();
     }
 
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options) : void
     {
         $transformer = new TextToEmailTransformer($this->domain);
 

tests/EntityListener/UserChangedListenerTest.php

@@ -30,15 +30,6 @@ public function setUp(): void
             ->willReturn($this->voucherRepository);
         $this->suspiciousChildrenHandler = $this->createMock(SuspiciousChildrenHandler::class);
         $this->listener = new UserChangedListener($manager, $this->suspiciousChildrenHandler);
-
-        $this->session = $this->createMock(Session::class);
-        $this->request = $this->createMock(Request::class);
-        $this->request->method('getSession')
-            ->willReturn($this->session);
-        $this->request->query = new InputBag();
-        $this->event = $this->createMock(RequestEvent::class);
-        $this->event->method('getRequest')
-            ->willReturn($this->request);
     }
 
     public function testPreUpdateNoRoleChanges(): void