✅ Enable Deprecation Helper in Tests #701
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x46616c6b
requested review from
doobry-systemli,
t2d and
y3n4
as code owners
0x46616c6b
force-pushed
the
Enable-Deprecation-Helper-in-Tests
branch
from
12b1351 to
3bbba31
Compare
t2d
force-pushed
the
Enable-Deprecation-Helper-in-Tests
branch
from
a94aaaa to
9152d1e
Compare
This reverts commit 9152d1e.
|
I couldn't silence the deprecation notice for tests of legacy code. We might have to update phpunit to 10+ first |
|
The problem is that we use deprecated service configurations for sonata admin bundle. Our controllers in the service configurations must use the tags instead of arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit should now fail if we have deprecations in our code base.