Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 WipeDisk annotation #1429

Merged
merged 16 commits into from
Aug 10, 2024
Merged

🌱 WipeDisk annotation #1429

merged 16 commits into from
Aug 10, 2024

Commits on Aug 9, 2024

  1. 🌱 WipeDisk annotation 

    Introduced annotation "wipedisk.hetznerbaremetalhost.infrastructure.cluster.x-k8s.io"

Set it to a space seperated list of WWNs or "all".

The given disks will be erased with `wipefs -af` before provisioning.

Once wipefs was executed the annotation gets removed.
    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d033579 View commit details
    Browse the repository at this point in the history

  2. .. addes shell script.

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d980cd5 View commit details
    Browse the repository at this point in the history

  3. .. use singular everywhere (wipeDisk not wipeDisks)

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    49369a0 View commit details
    Browse the repository at this point in the history

  4. increate timeout, hoping to decrease flakiness

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8190330 View commit details
    Browse the repository at this point in the history

  5. add output of wipefs to the event.

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a729dac View commit details
    Browse the repository at this point in the history

  6. better info msg.

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8825109 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into tg/wipefs-annotation

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    71982bd View commit details
    Browse the repository at this point in the history

  8. .. check if wwn is valid.

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    656c8d3 View commit details
    Browse the repository at this point in the history

  9. validate WWN, so that no code-injection can be done.

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d522002 View commit details
    Browse the repository at this point in the history

  10. fixed bug: errors.Is() does not work for ssh.ExitError. 

    For error structs, you need to use errors.As().
    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8990cf3 View commit details
    Browse the repository at this point in the history

  11. ... bash strict fails if not executed in a script 

    We might got during `trap`: sed: can't read bash: No such file or directory
    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e57357c View commit details
    Browse the repository at this point in the history

  12. ... typo

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5e4b159 View commit details
    Browse the repository at this point in the history

  13. colon is a valic char in a wwn.

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3adfcfc View commit details
    Browse the repository at this point in the history

  14. typo

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c8d317a View commit details
    Browse the repository at this point in the history

  15. typo

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6ee94a3 View commit details
    Browse the repository at this point in the history

  16. make linter happy (add comment to ErrInvalidWWN)

    @guettli
    guettli committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9c26632 View commit details
    Browse the repository at this point in the history